Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: ios/chrome/browser/ui/bookmarks/BUILD.gn

Issue 2737603007: [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC. (Closed)
Patch Set: fixed compile Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("bookmarks_arc_2") {
lpromero 2017/03/10 12:08:44 I didn't get why the sources files are not just ad
stkhapugin 2017/03/10 14:22:40 Yes, sorry, I forgot to merge this. Done.
6 configs += [ "//build/config/compiler:enable_arc" ]
7 sources = [
8 "bookmark_collection_cells.h",
9 "bookmark_collection_cells.mm",
10 "bookmark_collection_view.h",
11 "bookmark_collection_view.mm",
12 "bookmark_collection_view_background.h",
13 "bookmark_collection_view_background.mm",
14 "bookmark_controller_factory.h",
15 "bookmark_controller_factory.mm",
16 "bookmark_edit_view_controller.h",
17 "bookmark_edit_view_controller.mm",
18 "bookmark_elevated_toolbar.h",
19 "bookmark_elevated_toolbar.mm",
20 "bookmark_extended_button.h",
21 "bookmark_extended_button.mm",
22 "bookmark_folder_collection_view.h",
23 "bookmark_folder_collection_view.mm",
24 "bookmark_folder_editor_view_controller.h",
25 "bookmark_folder_editor_view_controller.mm",
26 "bookmark_folder_table_view_cell.h",
27 "bookmark_folder_table_view_cell.mm",
28 "bookmark_folder_view_controller.h",
29 "bookmark_folder_view_controller.mm",
30 ]
31 deps = [
32 ":resources",
33 "//base",
34 "//base:i18n",
35 "//components/bookmarks/browser",
36 "//components/favicon/core",
37 "//components/favicon_base",
38 "//components/pref_registry",
39 "//components/prefs",
40 "//components/query_parser",
41 "//components/signin/core/browser",
42 "//components/strings",
43 "//components/undo",
44 "//components/url_formatter",
45 "//google_apis",
46 "//ios/chrome/app/strings",
47 "//ios/chrome/app/theme",
48 "//ios/chrome/browser",
49 "//ios/chrome/browser/bookmarks",
50 "//ios/chrome/browser/bookmarks:bookmarks_utils",
51 "//ios/chrome/browser/browser_state",
52 "//ios/chrome/browser/favicon",
53 "//ios/chrome/browser/metrics:metrics_internal",
54 "//ios/chrome/browser/signin",
55 "//ios/chrome/browser/tabs",
56 "//ios/chrome/browser/ui",
57 "//ios/chrome/browser/ui/alert_coordinator",
58 "//ios/chrome/browser/ui/bookmarks/bars",
59 "//ios/chrome/browser/ui/bookmarks/cells",
60 "//ios/chrome/browser/ui/collection_view",
61 "//ios/chrome/browser/ui/collection_view/cells",
62 "//ios/chrome/browser/ui/colors",
63 "//ios/chrome/browser/ui/commands",
64 "//ios/chrome/browser/ui/icons",
65 "//ios/chrome/browser/ui/keyboard",
66 "//ios/chrome/browser/ui/material_components",
67 "//ios/chrome/browser/ui/ntp",
68 "//ios/chrome/browser/undo",
69 "//ios/public/provider/chrome/browser",
70 "//ios/public/provider/chrome/browser/ui",
71 "//ios/third_party/material_components_ios",
72 "//ios/third_party/material_roboto_font_loader_ios",
73 "//ios/web",
74 "//skia",
75 "//ui/base",
76 "//ui/gfx",
77 "//url",
78 ]
79 allow_circular_includes_from = [
80 "//ios/chrome/browser/ui/bookmarks/bars",
81 "//ios/chrome/browser/ui/bookmarks/cells",
82 ]
83 libs = [
84 "CoreGraphics.framework",
85 "QuartzCore.framework",
86 "UIKit.framework",
87 ]
88 }
89
5 source_set("bookmarks_arc") { 90 source_set("bookmarks_arc") {
6 configs += [ "//build/config/compiler:enable_arc" ] 91 configs += [ "//build/config/compiler:enable_arc" ]
7 sources = [ 92 sources = [
8 "bookmark_home_handset_view_controller.h", 93 "bookmark_home_handset_view_controller.h",
9 "bookmark_home_handset_view_controller.mm", 94 "bookmark_home_handset_view_controller.mm",
10 "bookmark_home_tablet_ntp_controller.h", 95 "bookmark_home_tablet_ntp_controller.h",
11 "bookmark_home_tablet_ntp_controller.mm", 96 "bookmark_home_tablet_ntp_controller.mm",
12 "bookmark_utils_ios.h", 97 "bookmark_utils_ios.h",
13 "bookmark_utils_ios.mm", 98 "bookmark_utils_ios.mm",
14 ] 99 ]
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 "//ios/public/provider/chrome/browser", 138 "//ios/public/provider/chrome/browser",
54 "//ios/public/provider/chrome/browser/ui", 139 "//ios/public/provider/chrome/browser/ui",
55 "//ios/third_party/material_components_ios", 140 "//ios/third_party/material_components_ios",
56 "//ios/third_party/material_roboto_font_loader_ios", 141 "//ios/third_party/material_roboto_font_loader_ios",
57 "//ios/web", 142 "//ios/web",
58 "//skia", 143 "//skia",
59 "//ui/base", 144 "//ui/base",
60 "//ui/gfx", 145 "//ui/gfx",
61 "//url", 146 "//url",
62 ] 147 ]
148 public_deps = [
149 ":bookmarks_arc_2",
150 ]
63 allow_circular_includes_from = [ 151 allow_circular_includes_from = [
64 "//ios/chrome/browser/ui/bookmarks/bars", 152 "//ios/chrome/browser/ui/bookmarks/bars",
65 "//ios/chrome/browser/ui/bookmarks/cells", 153 "//ios/chrome/browser/ui/bookmarks/cells",
154 ":bookmarks_arc_2",
66 ] 155 ]
67 libs = [ 156 libs = [
68 "CoreGraphics.framework", 157 "CoreGraphics.framework",
69 "QuartzCore.framework", 158 "QuartzCore.framework",
70 "UIKit.framework", 159 "UIKit.framework",
71 ] 160 ]
72 } 161 }
73 162
74 source_set("bookmarks") { 163 source_set("bookmarks") {
75 sources = [ 164 sources = [
76 "bookmark_collection_cells.h",
77 "bookmark_collection_cells.mm",
78 "bookmark_collection_view.h",
79 "bookmark_collection_view.mm",
80 "bookmark_collection_view_background.h",
81 "bookmark_collection_view_background.mm",
82 "bookmark_controller_factory.h",
83 "bookmark_controller_factory.mm",
84 "bookmark_edit_view_controller.h",
85 "bookmark_edit_view_controller.mm",
86 "bookmark_elevated_toolbar.h",
87 "bookmark_elevated_toolbar.mm",
88 "bookmark_extended_button.h",
89 "bookmark_extended_button.mm",
90 "bookmark_folder_collection_view.h",
91 "bookmark_folder_collection_view.mm",
92 "bookmark_folder_editor_view_controller.h",
93 "bookmark_folder_editor_view_controller.mm",
94 "bookmark_folder_table_view_cell.h",
95 "bookmark_folder_table_view_cell.mm",
96 "bookmark_folder_view_controller.h",
97 "bookmark_folder_view_controller.mm",
98 "bookmark_home_primary_view.h", 165 "bookmark_home_primary_view.h",
99 "bookmark_home_view_controller.h", 166 "bookmark_home_view_controller.h",
100 "bookmark_home_view_controller.mm", 167 "bookmark_home_view_controller.mm",
101 "bookmark_home_waiting_view.h", 168 "bookmark_home_waiting_view.h",
102 "bookmark_home_waiting_view.mm", 169 "bookmark_home_waiting_view.mm",
103 "bookmark_interaction_controller.h", 170 "bookmark_interaction_controller.h",
104 "bookmark_interaction_controller.mm", 171 "bookmark_interaction_controller.mm",
105 "bookmark_menu_cell.h", 172 "bookmark_menu_cell.h",
106 "bookmark_menu_cell.mm", 173 "bookmark_menu_cell.mm",
107 "bookmark_menu_item.h", 174 "bookmark_menu_item.h",
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 "//ios/third_party/material_components_ios", 235 "//ios/third_party/material_components_ios",
169 "//ios/third_party/material_roboto_font_loader_ios", 236 "//ios/third_party/material_roboto_font_loader_ios",
170 "//ios/web", 237 "//ios/web",
171 "//skia", 238 "//skia",
172 "//ui/base", 239 "//ui/base",
173 "//ui/gfx", 240 "//ui/gfx",
174 "//url", 241 "//url",
175 ] 242 ]
176 public_deps = [ 243 public_deps = [
177 ":bookmarks_arc", 244 ":bookmarks_arc",
245 ":bookmarks_arc_2",
178 ] 246 ]
179 allow_circular_includes_from = [ 247 allow_circular_includes_from = [
180 "//ios/chrome/browser/ui/bookmarks/bars", 248 "//ios/chrome/browser/ui/bookmarks/bars",
181 "//ios/chrome/browser/ui/bookmarks/cells", 249 "//ios/chrome/browser/ui/bookmarks/cells",
182 ":bookmarks_arc", 250 ":bookmarks_arc",
251 ":bookmarks_arc_2",
183 ] 252 ]
184 libs = [ 253 libs = [
185 "CoreGraphics.framework", 254 "CoreGraphics.framework",
186 "QuartzCore.framework", 255 "QuartzCore.framework",
187 "UIKit.framework", 256 "UIKit.framework",
188 ] 257 ]
189 } 258 }
190 259
191 source_set("unit_tests_arc") { 260 source_set("unit_tests_arc") {
192 configs += [ "//build/config/compiler:enable_arc" ] 261 configs += [ "//build/config/compiler:enable_arc" ]
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 "resources/bookmark_white_edit@2x.png", 397 "resources/bookmark_white_edit@2x.png",
329 "resources/bookmark_white_edit@3x.png", 398 "resources/bookmark_white_edit@3x.png",
330 "resources/bookmark_white_move.png", 399 "resources/bookmark_white_move.png",
331 "resources/bookmark_white_move@2x.png", 400 "resources/bookmark_white_move@2x.png",
332 "resources/bookmark_white_move@3x.png", 401 "resources/bookmark_white_move@3x.png",
333 ] 402 ]
334 outputs = [ 403 outputs = [
335 "{{bundle_resources_dir}}/{{source_file_part}}", 404 "{{bundle_resources_dir}}/{{source_file_part}}",
336 ] 405 ]
337 } 406 }
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698