Fix caret paint invalidation issue on partial lifecycle updates

Fix caret paint invalidation issue on partial lifecycle updates

Previously caret paint invalidation status was updated after FrameView's
layout. During a partial lifecyle update, the previous status, which was
supposed to be handled by the next paint invalidation tree walk, was
overriden, causing some invalidations were not handled.

Rename CaretDisplayItemClient::updateStyleAndLayoutIfNeeded() to
updateForPaintInvalidation() and call it from
FrameView::updateCaretsForPaintInvalidation().

It's still reasonable to let FrameView handle part of caret paint
invalidation because carets belongs to FrameViews. The real paint
invalidation is handled through LayoutBlock because carets are painted
by the containing LayoutBlock and we need the paint invalidation tree
walk context for paint invalidation.

BUG=699044
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[Xianzhu, 2017-03-07 20:08:32]

Description was changed from

==========
Fix caret paint invalidation issue on partial lifecycle updates

Previously caret paint invalidation status was updated after FrameView's
layout. During a partial lifecyle update, the previous status, which was
supposed to be handled by the next paint invalidation tree walk, was
overriden, causing some invalidations were not handled.

Rename CaretDisplayItemClient::updateStyleAndLayoutIfNeeded() to
updateForPaintInvalidation() and call it from
FrameView::updateCaretsForPaintInvalidation().

It's still reasonable to let FrameView handle part of caret paint
invalidation because carets belongs to FrameViews. The real paint
invalidation is handled through LayoutBlock because carets are painted
by the containing LayoutBlock and we need the paint invalidation tree
walk context for paint invalidation.

BUG=699044
==========

to

==========
Fix caret paint invalidation issue on partial lifecycle updates

Previously caret paint invalidation status was updated after FrameView's
layout. During a partial lifecyle update, the previous status, which was
supposed to be handled by the next paint invalidation tree walk, was
overriden, causing some invalidations were not handled.

Rename CaretDisplayItemClient::updateStyleAndLayoutIfNeeded() to
updateForPaintInvalidation() and call it from
FrameView::updateCaretsForPaintInvalidation().

It's still reasonable to let FrameView handle part of caret paint
invalidation because carets belongs to FrameViews. The real paint
invalidation is handled through LayoutBlock because carets are painted
by the containing LayoutBlock and we need the paint invalidation tree
walk context for paint invalidation.

BUG=699044
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-03-07 20:08:48]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2017-03-07 20:08:54]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-07 20:10:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 21:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 21:47:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2017-03-08 01:41:56]

https://codereview.chromium.org/2737043002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp
(right):

https://codereview.chromium.org/2737043002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp:54: void
updateAllLifecyclePhases() {
I assume some of the below failed otherwise? Just checking.

https://codereview.chromium.org/2737043002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2737043002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameView.cpp:5259: if
(m_frame->isMainFrame())
This conditional appears to be new. Is that correct? If so, why?

[Xianzhu, 2017-03-08 17:05:14]

Unfortunately the CL breaks editing/caret/caret-hidden-when-unfocused.html which
discovers an issue of this patch: paint invalidation flags are set too late and
may have no chance to set. Reworked as
https://codereview.chromium.org/2736213002/. Closing this one. Sorry for the
extra review works.