Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2737043002: Fix caret paint invalidation issue on partial lifecycle updates (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 void didLayout(); 199 void didLayout();
200 bool isAppearanceDirty() const; 200 bool isAppearanceDirty() const;
201 void commitAppearanceIfNeeded(LayoutView&); 201 void commitAppearanceIfNeeded(LayoutView&);
202 void setCaretVisible(bool caretIsVisible); 202 void setCaretVisible(bool caretIsVisible);
203 void scheduleVisualUpdate() const; 203 void scheduleVisualUpdate() const;
204 void scheduleVisualUpdateForPaintInvalidationIfNeeded() const; 204 void scheduleVisualUpdateForPaintInvalidationIfNeeded() const;
205 205
206 // Paint invalidation methods delegating to FrameCaret. 206 // Paint invalidation methods delegating to FrameCaret.
207 void clearPreviousCaretVisualRect(const LayoutBlock&); 207 void clearPreviousCaretVisualRect(const LayoutBlock&);
208 void layoutBlockWillBeDestroyed(const LayoutBlock&); 208 void layoutBlockWillBeDestroyed(const LayoutBlock&);
209 void updateStyleAndLayoutIfNeeded(); 209 void updateForPaintInvalidation();
210 void invalidatePaintIfNeeded(const LayoutBlock&, 210 void invalidatePaintIfNeeded(const LayoutBlock&,
211 const PaintInvalidatorContext&, 211 const PaintInvalidatorContext&,
212 PaintInvalidationReason); 212 PaintInvalidationReason);
213 213
214 void paintCaret(GraphicsContext&, const LayoutPoint&); 214 void paintCaret(GraphicsContext&, const LayoutPoint&);
215 215
216 // Used to suspend caret blinking while the mouse is down. 216 // Used to suspend caret blinking while the mouse is down.
217 void setCaretBlinkingSuspended(bool); 217 void setCaretBlinkingSuspended(bool);
218 bool isCaretBlinkingSuspended() const; 218 bool isCaretBlinkingSuspended() const;
219 219
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 324
325 } // namespace blink 325 } // namespace blink
326 326
327 #ifndef NDEBUG 327 #ifndef NDEBUG
328 // Outside the WebCore namespace for ease of invocation from gdb. 328 // Outside the WebCore namespace for ease of invocation from gdb.
329 void showTree(const blink::FrameSelection&); 329 void showTree(const blink::FrameSelection&);
330 void showTree(const blink::FrameSelection*); 330 void showTree(const blink::FrameSelection*);
331 #endif 331 #endif
332 332
333 #endif // FrameSelection_h 333 #endif // FrameSelection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698