Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.cpp

Issue 2737043002: Fix caret paint invalidation issue on partial lifecycle updates (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameCaret.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.cpp b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
index 0024a45b4226861398741ce2e980dcb1b0a3417d..5b952588bfc7e19675cdac9ecdc8ccfae64e4e9e 100644
--- a/third_party/WebKit/Source/core/editing/FrameCaret.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
@@ -133,7 +133,7 @@ void FrameCaret::layoutBlockWillBeDestroyed(const LayoutBlock& block) {
m_displayItemClient->layoutBlockWillBeDestroyed(block);
}
-void FrameCaret::updateStyleAndLayoutIfNeeded() {
+void FrameCaret::updateForPaintInvalidation() {
DCHECK_GE(m_frame->document()->lifecycle().state(),
DocumentLifecycle::LayoutClean);
updateAppearance();
@@ -142,7 +142,7 @@ void FrameCaret::updateStyleAndLayoutIfNeeded() {
m_caretVisibility == CaretVisibility::Visible &&
m_selectionEditor->computeVisibleSelectionInDOMTree().hasEditableStyle();
- m_displayItemClient->updateStyleAndLayoutIfNeeded(
+ m_displayItemClient->updateForPaintInvalidation(
shouldPaintCaret ? caretPosition() : PositionWithAffinity());
}

Powered by Google App Engine
This is Rietveld 408576698