Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h

Issue 2737043002: Fix caret paint invalidation issue on partial lifecycle updates (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h
diff --git a/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h b/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h
index 576381e0f7a23dae49da8521e18c93c24bd8a043..91bbf2e3f73c06912eaa341fc36f91e69617d5ca 100644
--- a/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h
+++ b/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h
@@ -69,9 +69,9 @@ class CaretDisplayItemClient final : public DisplayItemClient {
m_layoutBlock = nullptr;
}
- // Called when a FrameView finishes layout. Updates style and geometry of the
- // caret for paint invalidation and painting.
- void updateStyleAndLayoutIfNeeded(const PositionWithAffinity& caretPosition);
+ // Called before a FrameView starts paint invalidation. Updates style and
+ // geometry of the caret for paint invalidation and painting.
+ void updateForPaintInvalidation(const PositionWithAffinity& caretPosition);
// Called during LayoutBlock paint invalidation.
void invalidatePaintIfNeeded(

Powered by Google App Engine
This is Rietveld 408576698