Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2737043002: Fix caret paint invalidation issue on partial lifecycle updates (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 } 451 }
452 452
453 void FrameSelection::clearPreviousCaretVisualRect(const LayoutBlock& block) { 453 void FrameSelection::clearPreviousCaretVisualRect(const LayoutBlock& block) {
454 m_frameCaret->clearPreviousVisualRect(block); 454 m_frameCaret->clearPreviousVisualRect(block);
455 } 455 }
456 456
457 void FrameSelection::layoutBlockWillBeDestroyed(const LayoutBlock& block) { 457 void FrameSelection::layoutBlockWillBeDestroyed(const LayoutBlock& block) {
458 m_frameCaret->layoutBlockWillBeDestroyed(block); 458 m_frameCaret->layoutBlockWillBeDestroyed(block);
459 } 459 }
460 460
461 void FrameSelection::updateStyleAndLayoutIfNeeded() { 461 void FrameSelection::updateForPaintInvalidation() {
462 m_frameCaret->updateStyleAndLayoutIfNeeded(); 462 m_frameCaret->updateForPaintInvalidation();
463 } 463 }
464 464
465 void FrameSelection::invalidatePaintIfNeeded( 465 void FrameSelection::invalidatePaintIfNeeded(
466 const LayoutBlock& block, 466 const LayoutBlock& block,
467 const PaintInvalidatorContext& context, 467 const PaintInvalidatorContext& context,
468 PaintInvalidationReason reason) { 468 PaintInvalidationReason reason) {
469 m_frameCaret->invalidatePaintIfNeeded(block, context, reason); 469 m_frameCaret->invalidatePaintIfNeeded(block, context, reason);
470 } 470 }
471 471
472 bool FrameSelection::shouldPaintCaret(const LayoutBlock& block) const { 472 bool FrameSelection::shouldPaintCaret(const LayoutBlock& block) const {
(...skipping 702 matching lines...) Expand 10 before | Expand all | Expand 10 after
1175 } 1175 }
1176 1176
1177 void showTree(const blink::FrameSelection* sel) { 1177 void showTree(const blink::FrameSelection* sel) {
1178 if (sel) 1178 if (sel)
1179 sel->showTreeForThis(); 1179 sel->showTreeForThis();
1180 else 1180 else
1181 LOG(INFO) << "Cannot showTree for <null> FrameSelection."; 1181 LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
1182 } 1182 }
1183 1183
1184 #endif 1184 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698