Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2736493002: Fix two notification update issues on page navigation (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix two notification update issues on page navigation This CL fixes two issues that causes the notification to update improperly on navigation: * The notification should reset for same-origin but non-same-page navigation (in Java). * When the RenderFrameHost navigates away, the MediaSession members stored in MediaSessionServiceImpl should also be reset. BUG=696716 Review-Url: https://codereview.chromium.org/2723803002 Cr-Commit-Position: refs/heads/master@{#453906} (cherry picked from commit efb50702d432d69e593cf0bafb85ab82093d5395) Review-Url: https://codereview.chromium.org/2736493002 . Cr-Commit-Position: refs/branch-heads/2987@{#763} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/11cb9478bc228e4ddb88a916aceabc73ce3e777f

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-04 13:23:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
11cb9478bc228e4ddb88a916aceabc73ce3e777f.

Powered by Google App Engine
This is Rietveld 408576698