chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java - Issue 2736493002: Fix two notification update issues on page navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java

Issue 2736493002: Fix two notification update issues on page navigation (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTestUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java

index 105203e8c9beb597d0d43b9dc36ed4ff6bc67f54..3660c91b3971afa13ff475af2cdfa23883d3cf0a 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java

@@ -28,7 +28,7 @@ import java.util.Set;

public class NotificationActionsUpdatedTest extends ChromeActivityTestCaseBase<ChromeActivity> {

private static final int NOTIFICATION_ID = R.id.media_playback_notification;

- private static final String SIMPLE_PAGE_URL = "/simple_page.html";

+ private static final String SIMPLE_PAGE_URL = "/content/test/data/simple_page.html";

private Tab mTab;

private EmbeddedTestServer mTestServer;

@@ -75,14 +75,15 @@ public class NotificationActionsUpdatedTest extends ChromeActivityTestCaseBase<C

}

@SmallTest

- public void testActionsPersistAfterInPageNavigation() throws Throwable {

+ public void testActionsPersistAfterSamePageNavigation() throws Throwable {

ensureTestServer();

loadUrl(mTestServer.getURL(SIMPLE_PAGE_URL));

simulateMediaSessionActionsChanged(mTab, buildActions());

simulateMediaSessionStateChanged(mTab, true, false);

assertActionsMatch(buildActions());

- loadUrl(mTestServer.getURL(SIMPLE_PAGE_URL + "#some-anchor"));

+ NotificationTestUtils.simulateSamePageNavigation(

+ getInstrumentation(), mTab, mTestServer.getURL(SIMPLE_PAGE_URL));

assertActionsMatch(buildActions());

}