Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4202)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

Issue 2736493002: Fix two notification update issues on page navigation (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
index c49a01f85cd46a78358ccdb95cee6ce7325e2df9..263c13dd9f3b369de308595d21cbdda9509ae860 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
@@ -36,7 +36,8 @@ import org.chromium.net.test.EmbeddedTestServer;
@RetryOnFailure
public class NotificationTitleUpdatedTest extends ChromeActivityTestCaseBase<ChromeActivity> {
private static final int NOTIFICATION_ID = R.id.media_playback_notification;
- private static final String SIMPLE_PAGE_URL = "/simple_page.html";
+ private static final String SIMPLE_PAGE_URL_1 = "/content/test/data/title1.html";
+ private static final String SIMPLE_PAGE_URL_2 = "/content/test/data/title2.html";
private Tab mTab;
private EmbeddedTestServer mTestServer;
@@ -163,14 +164,28 @@ public class NotificationTitleUpdatedTest extends ChromeActivityTestCaseBase<Chr
}
@SmallTest
- public void testMediaMetadataPersistsAfterInPageNavigation() throws Throwable {
+ public void testMediaMetadataResetsAfterSameOriginNavigation() throws Throwable {
ensureTestServer();
- loadUrl(mTestServer.getURL(SIMPLE_PAGE_URL));
+ loadUrl(mTestServer.getURL(SIMPLE_PAGE_URL_1));
simulateMediaSessionStateChanged(mTab, true, false);
simulateMediaSessionMetadataChanged(mTab, new MediaMetadata("title2", "", ""));
assertTitleMatches("title2");
- loadUrl(mTestServer.getURL(SIMPLE_PAGE_URL + "#some-anchor"));
+ loadUrl(mTestServer.getURL(SIMPLE_PAGE_URL_2));
+ simulateUpdateTitle(mTab, "title3");
+ assertTitleMatches("title3");
+ }
+
+ @SmallTest
+ public void testMediaMetadataPersistsAfterSamePageNavigation() throws Throwable {
+ ensureTestServer();
+ loadUrl(mTestServer.getURL(SIMPLE_PAGE_URL_1));
+ simulateMediaSessionStateChanged(mTab, true, false);
+ simulateMediaSessionMetadataChanged(mTab, new MediaMetadata("title2", "", ""));
+ assertTitleMatches("title2");
+
+ NotificationTestUtils.simulateSamePageNavigation(
+ getInstrumentation(), mTab, mTestServer.getURL(SIMPLE_PAGE_URL_1));
assertTitleMatches("title2");
}

Powered by Google App Engine
This is Rietveld 408576698