Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: content/browser/media/session/media_session_impl.cc

Issue 2736493002: Fix two notification update issues on page navigation (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/media/session/media_session_impl.h" 5 #include "content/browser/media/session/media_session_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include "content/browser/media/session/audio_focus_delegate.h" 8 #include "content/browser/media/session/audio_focus_delegate.h"
9 #include "content/browser/media/session/media_session_controller.h" 9 #include "content/browser/media/session/media_session_controller.h"
10 #include "content/browser/media/session/media_session_player_observer.h" 10 #include "content/browser/media/session/media_session_player_observer.h"
11 #include "content/browser/media/session/media_session_service_impl.h" 11 #include "content/browser/media/session/media_session_service_impl.h"
12 #include "content/browser/web_contents/web_contents_impl.h" 12 #include "content/browser/web_contents/web_contents_impl.h"
13 #include "content/public/browser/media_session.h" 13 #include "content/public/browser/media_session.h"
14 #include "content/public/browser/media_session_observer.h" 14 #include "content/public/browser/media_session_observer.h"
15 #include "content/public/browser/navigation_handle.h"
15 #include "content/public/browser/web_contents.h" 16 #include "content/public/browser/web_contents.h"
16 #include "media/base/media_content_type.h" 17 #include "media/base/media_content_type.h"
17 18
18 #if defined(OS_ANDROID) 19 #if defined(OS_ANDROID)
19 #include "content/browser/media/session/media_session_android.h" 20 #include "content/browser/media/session/media_session_android.h"
20 #endif // defined(OS_ANDROID) 21 #endif // defined(OS_ANDROID)
21 22
22 namespace content { 23 namespace content {
23 24
24 namespace { 25 namespace {
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 pepper_players_.clear(); 109 pepper_players_.clear();
109 one_shot_players_.clear(); 110 one_shot_players_.clear();
110 AbandonSystemAudioFocusIfNeeded(); 111 AbandonSystemAudioFocusIfNeeded();
111 } 112 }
112 113
113 void MediaSessionImpl::RenderFrameDeleted(RenderFrameHost* rfh) { 114 void MediaSessionImpl::RenderFrameDeleted(RenderFrameHost* rfh) {
114 if (services_.count(rfh)) 115 if (services_.count(rfh))
115 OnServiceDestroyed(services_[rfh]); 116 OnServiceDestroyed(services_[rfh]);
116 } 117 }
117 118
119 void MediaSessionImpl::DidFinishNavigation(
120 NavigationHandle* navigation_handle) {
121 if (!navigation_handle->HasCommitted() || navigation_handle->IsSamePage())
122 return;
123
124 RenderFrameHost* rfh = navigation_handle->GetRenderFrameHost();
125 if (services_.count(rfh))
126 services_[rfh]->DidFinishNavigation();
127 }
128
118 void MediaSessionImpl::AddObserver(MediaSessionObserver* observer) { 129 void MediaSessionImpl::AddObserver(MediaSessionObserver* observer) {
119 observers_.AddObserver(observer); 130 observers_.AddObserver(observer);
120 } 131 }
121 132
122 void MediaSessionImpl::RemoveObserver(MediaSessionObserver* observer) { 133 void MediaSessionImpl::RemoveObserver(MediaSessionObserver* observer) {
123 observers_.RemoveObserver(observer); 134 observers_.RemoveObserver(observer);
124 } 135 }
125 136
126 void MediaSessionImpl::NotifyMediaSessionMetadataChange( 137 void MediaSessionImpl::NotifyMediaSessionMetadataChange(
127 const base::Optional<MediaMetadata>& metadata) { 138 const base::Optional<MediaMetadata>& metadata) {
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
709 if (!IsServiceActiveForRenderFrameHost(frame)) 720 if (!IsServiceActiveForRenderFrameHost(frame))
710 continue; 721 continue;
711 best_frame = frame; 722 best_frame = frame;
712 min_depth = depth; 723 min_depth = depth;
713 } 724 }
714 725
715 return best_frame ? services_[best_frame] : nullptr; 726 return best_frame ? services_[best_frame] : nullptr;
716 } 727 }
717 728
718 } // namespace content 729 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/media/session/media_session_impl.h ('k') | content/browser/media/session/media_session_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698