Rename SiteEngagementService::ResetScoreForURL.

Rename SiteEngagementService::ResetScoreForURL.

This method only resets the base score for a URL. It does not affect the
bonus score that an origin might receive, e.g. from being installed to
the user's desktop or homescreen. This means that getting the score of
an origin immediately after resetting it might return an unexpected
number.

This CL renames the method and adds a comment explicitly calling out the
potential difference.

BUG=699381
TBR=bauerb@chromium.org
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2735333002
Cr-Commit-Position: refs/heads/master@{#455918}
Committed: https://chromium.googlesource.com/chromium/src/+/e062cff433a3c2ee02cb9e45d480093a7b958272

[dominickn, 2017-03-08 05:08:07]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2017-03-08 05:08:09]

dominickn@chromium.org changed reviewers:
+ benwells@chromium.org

[dominickn, 2017-03-08 05:08:10]

PTAL thanks! I'll TBR other OWNERs when you're happy.

[commit-bot: I haz the power, 2017-03-08 05:08:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 05:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 05:54:18]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-03-08 06:21:08]

lgtm

[dominickn, 2017-03-08 06:26:42]

Description was changed from

==========
Rename SiteEngagementService::ResetScoreForURL.

This method only resets the base score for a URL. It does not affect the
bonus score that an origin might receive, e.g. from being installed to
the user's desktop or homescreen. This means that getting the score of
an origin immediately after resetting it might return an unexpected
number.

This CL renames the method and adds a comment explicitly calling out the
potential difference.

BUG=699381
==========

to

==========
Rename SiteEngagementService::ResetScoreForURL.

This method only resets the base score for a URL. It does not affect the
bonus score that an origin might receive, e.g. from being installed to
the user's desktop or homescreen. This means that getting the score of
an origin immediately after resetting it might return an unexpected
number.

This CL renames the method and adds a comment explicitly calling out the
potential difference.

BUG=699381
TBR=dfalcantara@chromium.org
TBR=peter@@chromium.org
TBR=bauerb@chromium.org
TBR=dbeam@chromium.org
==========

[Peter Beverloo, 2017-03-08 10:08:53]

peter@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-03-08 10:08:54]

budget and push lgtm

These tests do assume that there is no "persistency" score either. It may make
sense to ASSERT_EQ that that's zero as well at some point in the future.

[dominickn, 2017-03-09 23:23:50]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-03-09 23:24:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-03-10 00:10:23]

dominickn@chromium.org changed reviewers:
+ bauerb@chromium.org, dbeam@chromium.org, dfalcantara@chromium.org

[dominickn, 2017-03-10 00:11:17]

Description was changed from

==========
Rename SiteEngagementService::ResetScoreForURL.

This method only resets the base score for a URL. It does not affect the
bonus score that an origin might receive, e.g. from being installed to
the user's desktop or homescreen. This means that getting the score of
an origin immediately after resetting it might return an unexpected
number.

This CL renames the method and adds a comment explicitly calling out the
potential difference.

BUG=699381
TBR=dfalcantara@chromium.org
TBR=peter@@chromium.org
TBR=bauerb@chromium.org
TBR=dbeam@chromium.org
==========

to

==========
Rename SiteEngagementService::ResetScoreForURL.

This method only resets the base score for a URL. It does not affect the
bonus score that an origin might receive, e.g. from being installed to
the user's desktop or homescreen. This means that getting the score of
an origin immediately after resetting it might return an unexpected
number.

This CL renames the method and adds a comment explicitly calling out the
potential difference.

BUG=699381
TBR=bauerb@chromium.org
TBR=dbeam@chromium.org
==========

[dominickn, 2017-03-10 00:11:17]

dominickn@chromium.org changed reviewers:
- dfalcantara@chromium.org

[dominickn, 2017-03-10 00:11:37]

This CL is a method rename in the site engagement service. TBRing:

bauerb for java and plugins
dbeam for webui

[Dan Beam, 2017-03-10 00:12:35]

lgtm

[commit-bot: I haz the power, 2017-03-10 00:14:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489101830515820, "parent_rev":
"9b2ce42c3e9b02e8037b494a32a47cabd5f6e2a9", "commit_rev":
"e062cff433a3c2ee02cb9e45d480093a7b958272"}

[commit-bot: I haz the power, 2017-03-10 00:15:40]

Description was changed from

==========
Rename SiteEngagementService::ResetScoreForURL.

This method only resets the base score for a URL. It does not affect the
bonus score that an origin might receive, e.g. from being installed to
the user's desktop or homescreen. This means that getting the score of
an origin immediately after resetting it might return an unexpected
number.

This CL renames the method and adds a comment explicitly calling out the
potential difference.

BUG=699381
TBR=bauerb@chromium.org
TBR=dbeam@chromium.org
==========

to

==========
Rename SiteEngagementService::ResetScoreForURL.

This method only resets the base score for a URL. It does not affect the
bonus score that an origin might receive, e.g. from being installed to
the user's desktop or homescreen. This means that getting the score of
an origin immediately after resetting it might return an unexpected
number.

This CL renames the method and adds a comment explicitly calling out the
potential difference.

BUG=699381
TBR=bauerb@chromium.org
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2735333002
Cr-Commit-Position: refs/heads/master@{#455918}
Committed:
https://chromium.googlesource.com/chromium/src/+/e062cff433a3c2ee02cb9e45d480...
==========

[commit-bot: I haz the power, 2017-03-10 00:15:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e062cff433a3c2ee02cb9e45d480...