Rename SiteEngagementService::ResetScoreForURL.

chrome/browser/banners/app_banner_settings_helper_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "chrome/browser/engagement/site_engagement_service.h"
 #include "chrome/browser/installable/installable_logging.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
@@ skipping 74 matching lines @@
 
 TEST_F(AppBannerSettingsHelperTest, ShouldShowFromEngagement) {
   GURL url(kTestURL);
   SiteEngagementService* service = SiteEngagementService::Get(profile());
 
   // By default the banner should not be shown.
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
   // Add 1 engagement, it still should not be shown.
-  service->ResetScoreForURL(url, 1);
+  service->ResetBaseScoreForURL(url, 1);
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
   // Add 1 more engagement; now it should be shown.
-  service->ResetScoreForURL(url, 2);
+  service->ResetBaseScoreForURL(url, 2);
   EXPECT_TRUE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 }
 
 TEST_F(AppBannerSettingsHelperTest, ShouldNotShowAfterBlocking) {
   GURL url(kTestURL);
   NavigateAndCommit(url);
   SiteEngagementService* service = SiteEngagementService::Get(profile());
 
   base::Time reference_time = GetReferenceTime();
   base::Time two_months_ago = reference_time - base::TimeDelta::FromDays(60);
   base::Time one_year_ago = reference_time - base::TimeDelta::FromDays(366);
 
   // By default the banner should not be shown.
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
   // Add engagement such that the banner should show.
-  service->ResetScoreForURL(url, 4);
+  service->ResetBaseScoreForURL(url, 4);
   EXPECT_TRUE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
   EXPECT_EQ(NO_ERROR_DETECTED,
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, reference_time));
 
   // Block the site a long time ago. It should still be shown.
   AppBannerSettingsHelper::RecordBannerEvent(
       web_contents(), url, kTestPackageName,
       AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK, one_year_ago);
@@ skipping 24 matching lines @@
 
   base::Time reference_time = GetReferenceTime();
   base::Time one_week_ago = reference_time - base::TimeDelta::FromDays(7);
   base::Time one_year_ago = reference_time - base::TimeDelta::FromDays(366);
 
   // By default the banner should not be shown.
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
   // Add engagement such that the banner should show.
-  service->ResetScoreForURL(url, 4);
+  service->ResetBaseScoreForURL(url, 4);
   EXPECT_TRUE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
   EXPECT_EQ(NO_ERROR_DETECTED,
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, reference_time));
 
   // Show the banner a long time ago. It should still be shown.
   AppBannerSettingsHelper::RecordBannerEvent(
       web_contents(), url, kTestPackageName,
       AppBannerSettingsHelper::APP_BANNER_EVENT_DID_SHOW, one_year_ago);
@@ skipping 22 matching lines @@
   SiteEngagementService* service = SiteEngagementService::Get(profile());
 
   base::Time reference_time = GetReferenceTime();
   base::Time one_year_ago = reference_time - base::TimeDelta::FromDays(366);
 
   // By default the banner should not be shown.
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
   // Add engagement such that the banner should show.
-  service->ResetScoreForURL(url, 4);
+  service->ResetBaseScoreForURL(url, 4);
   EXPECT_TRUE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
   EXPECT_EQ(NO_ERROR_DETECTED,
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, reference_time));
 
   // Add the site a long time ago. It should not be shown.
   AppBannerSettingsHelper::RecordBannerEvent(
       web_contents(), url, kTestPackageName,
       AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
       one_year_ago);
   EXPECT_EQ(ALREADY_INSTALLED,
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, reference_time));
 }
 
 TEST_F(AppBannerSettingsHelperTest, OperatesOnOrigins) {
   GURL url(kTestURL);
   SiteEngagementService* service = SiteEngagementService::Get(profile());
 
   // By default the banner should not be shown.
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
   // Add engagement such that the banner should show.
-  service->ResetScoreForURL(url, 4);
+  service->ResetBaseScoreForURL(url, 4);
   EXPECT_TRUE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
   // Try another page on the same origin.
   url = GURL(kSameOriginTestURL);
 
   // The banner should show as settings are per-origin.
   EXPECT_TRUE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
   EXPECT_EQ(NO_ERROR_DETECTED,
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, GetReferenceTime()));
 }
 
 TEST_F(AppBannerSettingsHelperTest, ShouldShowWithHigherTotal) {
   AppBannerSettingsHelper::SetTotalEngagementToTrigger(10);
   GURL url(kTestURL);
   SiteEngagementService* service = SiteEngagementService::Get(profile());
 
   // By default the banner should not be shown.
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
   // Add engagement such that the banner should show.
-  service->ResetScoreForURL(url, 2);
+  service->ResetBaseScoreForURL(url, 2);
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
-  service->ResetScoreForURL(url, 4);
+  service->ResetBaseScoreForURL(url, 4);
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
-  service->ResetScoreForURL(url, 6);
+  service->ResetBaseScoreForURL(url, 6);
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
-  service->ResetScoreForURL(url, 8);
+  service->ResetBaseScoreForURL(url, 8);
   EXPECT_FALSE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
-  service->ResetScoreForURL(url, 10);
+  service->ResetBaseScoreForURL(url, 10);
   EXPECT_TRUE(
       AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
 
   EXPECT_EQ(NO_ERROR_DETECTED,
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, GetReferenceTime()));
 }
 
 TEST_F(AppBannerSettingsHelperTest, WasLaunchedRecently) {
   GURL url(kTestURL);
@@ skipping 56 matching lines @@
       first_day);
   EXPECT_TRUE(
       AppBannerSettingsHelper::WasLaunchedRecently(profile(), url, first_day));
   EXPECT_TRUE(
       AppBannerSettingsHelper::WasLaunchedRecently(profile(), url, ninth_day));
   EXPECT_TRUE(
       AppBannerSettingsHelper::WasLaunchedRecently(profile(), url, tenth_day));
   EXPECT_TRUE(AppBannerSettingsHelper::WasLaunchedRecently(profile(), url,
                                                            eleventh_day));
 }