Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: chrome/browser/engagement/important_sites_util_unittest.cc

Issue 2735333002: Rename SiteEngagementService::ResetScoreForURL. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/important_sites_util_unittest.cc
diff --git a/chrome/browser/engagement/important_sites_util_unittest.cc b/chrome/browser/engagement/important_sites_util_unittest.cc
index 028eb7c3c8017aea8fe935de22ef2b570c98b9b2..20eea71e223c51498aff03fa52580bfa5afbf12f 100644
--- a/chrome/browser/engagement/important_sites_util_unittest.cc
+++ b/chrome/browser/engagement/important_sites_util_unittest.cc
@@ -154,13 +154,13 @@ TEST_F(ImportantSitesUtilTest, SourceOrdering) {
GURL url6("https://youtube.com/");
GURL url7("https://foo.bar/");
- service->ResetScoreForURL(url1, 5);
- service->ResetScoreForURL(url2, 2); // Below medium engagement (5).
- service->ResetScoreForURL(url3, 7);
- service->ResetScoreForURL(url4, 8);
- service->ResetScoreForURL(url5, 9);
- service->ResetScoreForURL(url6, 1); // Below the medium engagement (5).
- service->ResetScoreForURL(url7, 11);
+ service->ResetBaseScoreForURL(url1, 5);
+ service->ResetBaseScoreForURL(url2, 2); // Below medium engagement (5).
+ service->ResetBaseScoreForURL(url3, 7);
+ service->ResetBaseScoreForURL(url4, 8);
+ service->ResetBaseScoreForURL(url5, 9);
+ service->ResetBaseScoreForURL(url6, 1); // Below the medium engagement (5).
+ service->ResetBaseScoreForURL(url7, 11);
// Here we should have:
// 1: removed domains below minimum engagement,
@@ -239,9 +239,9 @@ TEST_F(ImportantSitesUtilTest, TooManyBookmarks) {
// If we add some site engagement, they should show up (even though the site
// engagement score is too low for a signal by itself).
- service->ResetScoreForURL(url1, 2);
- service->ResetScoreForURL(url4, 3);
- service->ResetScoreForURL(url7, 0);
+ service->ResetBaseScoreForURL(url1, 2);
+ service->ResetBaseScoreForURL(url4, 3);
+ service->ResetBaseScoreForURL(url7, 0);
important_sites = ImportantSitesUtil::GetImportantRegisterableDomains(
profile(), kNumImportantSites);
@@ -261,7 +261,7 @@ TEST_F(ImportantSitesUtilTest, Blacklisting) {
GURL url2("http://www.gmail.com/");
// Set a bunch of positive signals.
- service->ResetScoreForURL(url1, 5);
+ service->ResetBaseScoreForURL(url1, 5);
AddBookmark(url2);
AddContentSetting(CONTENT_SETTINGS_TYPE_NOTIFICATIONS, CONTENT_SETTING_ALLOW,
url1);
@@ -316,7 +316,7 @@ TEST_F(ImportantSitesUtilTest, BlacklistingReset) {
GURL url2("http://www.gmail.com/");
// Set a bunch of positive signals.
- service->ResetScoreForURL(url1, 5);
+ service->ResetBaseScoreForURL(url1, 5);
AddBookmark(url2);
AddContentSetting(CONTENT_SETTINGS_TYPE_NOTIFICATIONS, CONTENT_SETTING_ALLOW,
url1);
@@ -385,7 +385,7 @@ TEST_F(ImportantSitesUtilTest, Metrics) {
base::HistogramTester histogram_tester;
GURL url1("http://www.google.com/");
- service->ResetScoreForURL(url1, 5);
+ service->ResetBaseScoreForURL(url1, 5);
AddContentSetting(CONTENT_SETTINGS_TYPE_NOTIFICATIONS, CONTENT_SETTING_ALLOW,
url1);
@@ -430,7 +430,7 @@ TEST_F(ImportantSitesUtilTest, DialogBlacklisting) {
GURL url2("http://www.yahoo.com/");
// Set a bunch of positive signals.
- service->ResetScoreForURL(url2, 5);
+ service->ResetBaseScoreForURL(url2, 5);
AddBookmark(url1);
AddContentSetting(CONTENT_SETTINGS_TYPE_NOTIFICATIONS, CONTENT_SETTING_ALLOW,
url1);
« no previous file with comments | « chrome/browser/engagement/important_sites_util.cc ('k') | chrome/browser/engagement/site_engagement_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698