Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: chrome/browser/banners/app_banner_settings_helper_unittest.cc

Issue 2735333002: Rename SiteEngagementService::ResetScoreForURL. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_settings_helper_unittest.cc
diff --git a/chrome/browser/banners/app_banner_settings_helper_unittest.cc b/chrome/browser/banners/app_banner_settings_helper_unittest.cc
index a4035e9653ac5d8d8ee8f5434f7a07ea00dd4c4c..84d1a031d5836048349f3c77e2ec661c065ab077 100644
--- a/chrome/browser/banners/app_banner_settings_helper_unittest.cc
+++ b/chrome/browser/banners/app_banner_settings_helper_unittest.cc
@@ -92,12 +92,12 @@ TEST_F(AppBannerSettingsHelperTest, ShouldShowFromEngagement) {
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
// Add 1 engagement, it still should not be shown.
- service->ResetScoreForURL(url, 1);
+ service->ResetBaseScoreForURL(url, 1);
EXPECT_FALSE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
// Add 1 more engagement; now it should be shown.
- service->ResetScoreForURL(url, 2);
+ service->ResetBaseScoreForURL(url, 2);
EXPECT_TRUE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
}
@@ -116,7 +116,7 @@ TEST_F(AppBannerSettingsHelperTest, ShouldNotShowAfterBlocking) {
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
// Add engagement such that the banner should show.
- service->ResetScoreForURL(url, 4);
+ service->ResetBaseScoreForURL(url, 4);
EXPECT_TRUE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
EXPECT_EQ(NO_ERROR_DETECTED,
@@ -161,7 +161,7 @@ TEST_F(AppBannerSettingsHelperTest, ShouldNotShowAfterShowing) {
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
// Add engagement such that the banner should show.
- service->ResetScoreForURL(url, 4);
+ service->ResetBaseScoreForURL(url, 4);
EXPECT_TRUE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
EXPECT_EQ(NO_ERROR_DETECTED,
@@ -204,7 +204,7 @@ TEST_F(AppBannerSettingsHelperTest, ShouldNotShowAfterAdding) {
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
// Add engagement such that the banner should show.
- service->ResetScoreForURL(url, 4);
+ service->ResetBaseScoreForURL(url, 4);
EXPECT_TRUE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
EXPECT_EQ(NO_ERROR_DETECTED,
@@ -230,7 +230,7 @@ TEST_F(AppBannerSettingsHelperTest, OperatesOnOrigins) {
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
// Add engagement such that the banner should show.
- service->ResetScoreForURL(url, 4);
+ service->ResetBaseScoreForURL(url, 4);
EXPECT_TRUE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
@@ -255,23 +255,23 @@ TEST_F(AppBannerSettingsHelperTest, ShouldShowWithHigherTotal) {
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
// Add engagement such that the banner should show.
- service->ResetScoreForURL(url, 2);
+ service->ResetBaseScoreForURL(url, 2);
EXPECT_FALSE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
- service->ResetScoreForURL(url, 4);
+ service->ResetBaseScoreForURL(url, 4);
EXPECT_FALSE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
- service->ResetScoreForURL(url, 6);
+ service->ResetBaseScoreForURL(url, 6);
EXPECT_FALSE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
- service->ResetScoreForURL(url, 8);
+ service->ResetBaseScoreForURL(url, 8);
EXPECT_FALSE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
- service->ResetScoreForURL(url, 10);
+ service->ResetBaseScoreForURL(url, 10);
EXPECT_TRUE(
AppBannerSettingsHelper::HasSufficientEngagement(service->GetScore(url)));
« no previous file with comments | « chrome/browser/banners/app_banner_manager_browsertest.cc ('k') | chrome/browser/budget_service/budget_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698