Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2734883002: ICData::NumberOfChecks is O(n) so don't call it in loops (Closed)

Created:
3 years, 9 months ago by erikcorry
Modified:
3 years, 9 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ICData::NumberOfChecks is O(n) so don't call it in loops R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/634a9a673aaee35f75ba8884f3ebdd6b26c7cbda

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -98 lines) Patch
M runtime/vm/aot_optimizer.cc View 1 11 chunks +18 lines, -18 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 5 chunks +12 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/jit_optimizer.cc View 1 10 chunks +19 lines, -15 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 7 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
erikcorry
3 years, 9 months ago (2017-03-06 15:21:03 UTC) #1
kustermann
LGTM https://codereview.chromium.org/2734883002/diff/1/runtime/vm/aot_optimizer.cc File runtime/vm/aot_optimizer.cc (right): https://codereview.chromium.org/2734883002/diff/1/runtime/vm/aot_optimizer.cc#newcode1306 runtime/vm/aot_optimizer.cc:1306: intptr_t number_of_checks = ic_data.NumberOfChecks(); const - also further ...
3 years, 9 months ago (2017-03-06 15:31:48 UTC) #2
erikcorry
3 years, 9 months ago (2017-03-06 16:03:29 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
634a9a673aaee35f75ba8884f3ebdd6b26c7cbda (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698