runtime/vm/intermediate_language.h - Issue 2734883002: ICData::NumberOfChecks is O(n) so don't call it in loops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.h

Issue 2734883002: ICData::NumberOfChecks is O(n) so don't call it in loops (Closed)

Patch Set: Add const Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language.h

diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h

index b58d9bf41e1c5310a63dcf474dfec02cc5c4bd49..15f51b587bf39bbee1a59159b166848899122c98 100644

--- a/runtime/vm/intermediate_language.h

+++ b/runtime/vm/intermediate_language.h

@@ -2793,7 +2793,7 @@ class PolymorphicInstanceCallInstr : public TemplateDefinition<0, Throws> {

with_checks_(with_checks),

complete_(complete) {

ASSERT(instance_call_ != NULL);

- ASSERT(ic_data.NumberOfChecks() > 0);

+ ASSERT(!ic_data.NumberOfChecksIs(0));

}

InstanceCallInstr* instance_call() const { return instance_call_; }

« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »