runtime/vm/flow_graph_type_propagator.cc - Issue 2734883002: ICData::NumberOfChecks is O(n) so don't call it in loops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 2734883002: ICData::NumberOfChecks is O(n) so don't call it in loops (Closed)

Patch Set: Add const Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_type_propagator.cc

diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc

index d3cdc8418fb36da18f6e90f63ddd8fb341df80a6..7e88f12e77687684fab3ec84e10a51ce0aad2ac6 100644

--- a/runtime/vm/flow_graph_type_propagator.cc

+++ b/runtime/vm/flow_graph_type_propagator.cc

@@ -219,7 +219,7 @@ void FlowGraphTypePropagator::VisitCheckArrayBound(

void FlowGraphTypePropagator::VisitCheckClass(CheckClassInstr* check) {

- if ((check->unary_checks().NumberOfChecks() != 1) ||

+ if (!check->unary_checks().NumberOfChecksIs(1) ||

!check->Dependencies().IsNone()) {

// TODO(vegorov): If check is affected by side-effect we can still propagate

// the type further but not the cid.

« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »