Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 2734883002: ICData::NumberOfChecks is O(n) so don't call it in loops (Closed)
Patch Set: Add const Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 5298 matching lines...) Expand 10 before | Expand all | Expand 10 after
5309 Label do_call, done; 5309 Label do_call, done;
5310 // Check for overflow and that it fits into Smi. 5310 // Check for overflow and that it fits into Smi.
5311 __ cmpl(result, Immediate(0xC0000000)); 5311 __ cmpl(result, Immediate(0xC0000000));
5312 __ j(NEGATIVE, &do_call, Assembler::kNearJump); 5312 __ j(NEGATIVE, &do_call, Assembler::kNearJump);
5313 __ SmiTag(result); 5313 __ SmiTag(result);
5314 __ jmp(&done); 5314 __ jmp(&done);
5315 __ Bind(&do_call); 5315 __ Bind(&do_call);
5316 __ pushl(value_obj); 5316 __ pushl(value_obj);
5317 ASSERT(instance_call()->HasICData()); 5317 ASSERT(instance_call()->HasICData());
5318 const ICData& ic_data = *instance_call()->ic_data(); 5318 const ICData& ic_data = *instance_call()->ic_data();
5319 ASSERT((ic_data.NumberOfChecks() == 1)); 5319 ASSERT(ic_data.NumberOfChecksIs(1));
5320 const Function& target = Function::ZoneHandle(ic_data.GetTargetAt(0)); 5320 const Function& target = Function::ZoneHandle(ic_data.GetTargetAt(0));
5321 5321
5322 const intptr_t kNumberOfArguments = 1; 5322 const intptr_t kNumberOfArguments = 1;
5323 compiler->GenerateStaticCall(deopt_id(), instance_call()->token_pos(), target, 5323 compiler->GenerateStaticCall(deopt_id(), instance_call()->token_pos(), target,
5324 kNumberOfArguments, 5324 kNumberOfArguments,
5325 Object::null_array(), // No argument names. 5325 Object::null_array(), // No argument names.
5326 locs(), ICData::Handle()); 5326 locs(), ICData::Handle());
5327 __ Bind(&done); 5327 __ Bind(&done);
5328 } 5328 }
5329 5329
(...skipping 1542 matching lines...) Expand 10 before | Expand all | Expand 10 after
6872 __ Drop(1); 6872 __ Drop(1);
6873 __ popl(result); 6873 __ popl(result);
6874 } 6874 }
6875 6875
6876 6876
6877 } // namespace dart 6877 } // namespace dart
6878 6878
6879 #undef __ 6879 #undef __
6880 6880
6881 #endif // defined TARGET_ARCH_IA32 6881 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698