ICData::NumberOfChecks is O(n) so don't call it in loops

runtime/vm/flow_graph_compiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_XXX.
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
@@ skipping 143 matching lines @@
 
 // Returns true if OnebyteString is a frequent receiver class. We inline
 // Smi check as well, since a Smi check must be done anyway.
 // TODO(srdjan): Add check and code if Smi class is hot.
 bool FlowGraphCompiler::ShouldInlineSmiStringHashCode(const ICData& ic_data) {
   if (!FLAG_inline_smi_string_hashcode ||
       (ic_data.target_name() != Symbols::hashCode().raw())) {
     return false;
   }
   // Precompiled code has no ICData, optimistically inline it.
-  if (ic_data.IsNull() || (ic_data.NumberOfChecks() == 0)) {
+  if (ic_data.IsNull() || ic_data.NumberOfChecksIs(0)) {
     return true;
   }
   // Check if OneByteString is hot enough.
   const ICData& ic_data_sorted =
       ICData::Handle(ic_data.AsUnaryClassChecksSortedByCount());
-  ASSERT(ic_data_sorted.NumberOfChecks() > 0);
+  ASSERT(!ic_data_sorted.NumberOfChecksIs(0));
   if (ic_data_sorted.GetReceiverClassIdAt(0) == kOneByteStringCid) {
     const intptr_t total_count = ic_data_sorted.AggregateCount();
     const intptr_t ratio = (ic_data_sorted.GetCountAt(0) * 100) / total_count;
     return ratio > FLAG_inline_smi_string_hashcode_ratio;
   }
   return false;
 }
 
 
 FlowGraphCompiler::FlowGraphCompiler(
@@ skipping 1705 matching lines @@
 
 
 void FlowGraphCompiler::FrameStateClear() {
   ASSERT(!is_optimizing());
   frame_state_.TruncateTo(0);
 }
 #endif  // defined(DEBUG) && !defined(TARGET_ARCH_DBC)
 
 
 }  // namespace dart