Add check for missing visual rect updates and fix failures

Add check for missing visual rect updates and fix failures

Check if visual rect will change when an object is walked during
PrePaintTreeWalk but the object is not marked for checking paint
invalidation.

Found and fixed several issues:
- when a frame is relocated,set the LayoutView mayNeedPaintInvalidation().
- For clip change detection, we should not reset
  ancestorTransformedOrRootPaintLayer on sub frames.
- For SPv2, computeLocationInBacking() should just return paintOffset
  because the "backing" is the enclosing transform node.
- When LayoutTable's visual rect changes, we should check for paint
  invalidation of all LayoutTableCols which use LayoutTable's
  localVisualRect() as theirs.
- Don't inflate for filter if the filter is on a composited layer.

Also fixed flakiness of paint/invalidation/resize-iframe-text.html
(which discovered the clip change detection issue).

BUG=636271
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2733773004
Cr-Commit-Position: refs/heads/master@{#455266}
Committed: https://chromium.googlesource.com/chromium/src/+/2c0032c9ca74bd03925a7367f4482e4ec6f06278

[Xianzhu, 2017-03-06 20:54:10]

Description was changed from

==========
Add check for missing visual rect updates and fix failures

Check if visual rect will change when an object is walked during
PrePaintTreeWalk but the object is not marked for checking paint
invalidation.

Found and fixed several issues:
- (non-rootLayerScrolling only): when a frame is relocated, we need
  to set the LayoutView mayNeedPaintInvalidation().
- For clip change detection, we should not reset
  ancestorTransformedOrRootPaintLayer on sub frames.
- For SPv2, computeLocationInBacking() should just return paintOffset
  because the "backing" is the enclosing transform node.

Also fixed flakiness of paint/invalidation/resize-iframe-text.html
(which discovered the clip change detection issue).

BUG=636271
==========

to

==========
Add check for missing visual rect updates and fix failures

Check if visual rect will change when an object is walked during
PrePaintTreeWalk but the object is not marked for checking paint
invalidation.

Found and fixed several issues:
- (non-rootLayerScrolling only): when a frame is relocated, we need
  to set the LayoutView mayNeedPaintInvalidation().
- For clip change detection, we should not reset
  ancestorTransformedOrRootPaintLayer on sub frames.
- For SPv2, computeLocationInBacking() should just return paintOffset
  because the "backing" is the enclosing transform node.

Also fixed flakiness of paint/invalidation/resize-iframe-text.html
(which discovered the clip change detection issue).

BUG=636271
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-03-06 20:55:13]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 20:55:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-03-06 20:55:41]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-06 21:42:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 21:42:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chrishtr, 2017-03-06 22:44:28]

https://codereview.chromium.org/2733773004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp (right):

https://codereview.chromium.org/2733773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp:56:
setBodyInnerHTML(
if (REF::rootLayerScrollingEnabled())
  return

?

[Xianzhu, 2017-03-07 00:21:46]

Description was changed from

==========
Add check for missing visual rect updates and fix failures

Check if visual rect will change when an object is walked during
PrePaintTreeWalk but the object is not marked for checking paint
invalidation.

Found and fixed several issues:
- (non-rootLayerScrolling only): when a frame is relocated, we need
  to set the LayoutView mayNeedPaintInvalidation().
- For clip change detection, we should not reset
  ancestorTransformedOrRootPaintLayer on sub frames.
- For SPv2, computeLocationInBacking() should just return paintOffset
  because the "backing" is the enclosing transform node.

Also fixed flakiness of paint/invalidation/resize-iframe-text.html
(which discovered the clip change detection issue).

BUG=636271
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add check for missing visual rect updates and fix failures

Check if visual rect will change when an object is walked during
PrePaintTreeWalk but the object is not marked for checking paint
invalidation.

Found and fixed several issues:
- when a frame is relocated,set the LayoutView mayNeedPaintInvalidation().
- For clip change detection, we should not reset
  ancestorTransformedOrRootPaintLayer on sub frames.
- For SPv2, computeLocationInBacking() should just return paintOffset
  because the "backing" is the enclosing transform node.
- When LayoutTable's visual rect changes, we should check for paint
  invalidation of all LayoutTableCols which use LayoutTable's
  localVisualRect() as theirs.
- Don't inflate for filter if the filter is on a composited layer.

Also fixed flakiness of paint/invalidation/resize-iframe-text.html
(which discovered the clip change detection issue).

BUG=636271
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-03-07 00:21:50]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2017-03-07 00:22:08]

Also fixed two more cases of failures.

https://codereview.chromium.org/2733773004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp (right):

https://codereview.chromium.org/2733773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp:56:
setBodyInnerHTML(
On 2017/03/06 22:44:27, chrishtr wrote:
> if (REF::rootLayerScrollingEnabled())
>   return
> 
> ?

This test should still pass for rootLayerScrolling().

I converted the test to parameterized test, but it failed with
rootLayerScrolling() enabled. Fixed by moving the added
setMayNeedPaintInvalidation() in FrameView::setFrameRect() out of the REF
conditions.

[commit-bot: I haz the power, 2017-03-07 00:22:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-07 00:27:42]

lgtm

[commit-bot: I haz the power, 2017-03-07 01:10:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:10:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-03-07 02:22:13]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-07 02:22:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2733773004/#ps40001
(title: "-")

[commit-bot: I haz the power, 2017-03-07 02:22:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 03:30:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:30:17]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2017-03-07 06:01:30]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-07 06:02:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-03-07 06:29:28]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-07 06:29:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2733773004/#ps60001
(title: "-")

[commit-bot: I haz the power, 2017-03-07 06:29:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 08:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:44:00]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xianzhu, 2017-03-07 16:48:47]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-07 16:50:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:48:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488905327290090,
"parent_rev": "7100c1b09f742260b741c1cd717b8f449e0f8eb2", "commit_rev":
"2c0032c9ca74bd03925a7367f4482e4ec6f06278"}

[commit-bot: I haz the power, 2017-03-07 22:48:55]

Description was changed from

==========
Add check for missing visual rect updates and fix failures

Check if visual rect will change when an object is walked during
PrePaintTreeWalk but the object is not marked for checking paint
invalidation.

Found and fixed several issues:
- when a frame is relocated,set the LayoutView mayNeedPaintInvalidation().
- For clip change detection, we should not reset
  ancestorTransformedOrRootPaintLayer on sub frames.
- For SPv2, computeLocationInBacking() should just return paintOffset
  because the "backing" is the enclosing transform node.
- When LayoutTable's visual rect changes, we should check for paint
  invalidation of all LayoutTableCols which use LayoutTable's
  localVisualRect() as theirs.
- Don't inflate for filter if the filter is on a composited layer.

Also fixed flakiness of paint/invalidation/resize-iframe-text.html
(which discovered the clip change detection issue).

BUG=636271
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add check for missing visual rect updates and fix failures

Check if visual rect will change when an object is walked during
PrePaintTreeWalk but the object is not marked for checking paint
invalidation.

Found and fixed several issues:
- when a frame is relocated,set the LayoutView mayNeedPaintInvalidation().
- For clip change detection, we should not reset
  ancestorTransformedOrRootPaintLayer on sub frames.
- For SPv2, computeLocationInBacking() should just return paintOffset
  because the "backing" is the enclosing transform node.
- When LayoutTable's visual rect changes, we should check for paint
  invalidation of all LayoutTableCols which use LayoutTable's
  localVisualRect() as theirs.
- Don't inflate for filter if the filter is on a composited layer.

Also fixed flakiness of paint/invalidation/resize-iframe-text.html
(which discovered the clip change detection issue).

BUG=636271
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2733773004
Cr-Commit-Position: refs/heads/master@{#455266}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c0032c9ca74bd03925a7367f448...
==========

[commit-bot: I haz the power, 2017-03-07 22:48:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2c0032c9ca74bd03925a7367f448...

[wkorman, 2017-03-07 23:00:33]

On 2017/03/07 22:48:56, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:60001) as
>
https://chromium.googlesource.com/chromium/src/+/2c0032c9ca74bd03925a7367f448...

This change sounds amazing!