Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2733773004: Add check for missing visual rect updates and fix failures (Closed)
Patch Set: - Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2444 matching lines...) Expand 10 before | Expand all | Expand 10 after
2455 return toLayoutView(container)->mapToVisualRectInAncestorSpaceInternal( 2455 return toLayoutView(container)->mapToVisualRectInAncestorSpaceInternal(
2456 ancestor, transformState, position == EPosition::kFixed ? IsFixed : 0, 2456 ancestor, transformState, position == EPosition::kFixed ? IsFixed : 0,
2457 visualRectFlags); 2457 visualRectFlags);
2458 else 2458 else
2459 return container->mapToVisualRectInAncestorSpaceInternal( 2459 return container->mapToVisualRectInAncestorSpaceInternal(
2460 ancestor, transformState, visualRectFlags); 2460 ancestor, transformState, visualRectFlags);
2461 } 2461 }
2462 2462
2463 void LayoutBox::inflateVisualRectForFilter( 2463 void LayoutBox::inflateVisualRectForFilter(
2464 TransformState& transformState) const { 2464 TransformState& transformState) const {
2465 if (!layer() || !layer()->hasFilterInducingProperty()) 2465 if (!layer() || !layer()->paintsWithFilters())
2466 return; 2466 return;
2467 2467
2468 transformState.flatten(); 2468 transformState.flatten();
2469 LayoutRect rect(transformState.lastPlanarQuad().boundingBox()); 2469 LayoutRect rect(transformState.lastPlanarQuad().boundingBox());
2470 transformState.setQuad( 2470 transformState.setQuad(
2471 FloatQuad(FloatRect(layer()->mapLayoutRectForFilter(rect)))); 2471 FloatQuad(FloatRect(layer()->mapLayoutRectForFilter(rect))));
2472 } 2472 }
2473 2473
2474 void LayoutBox::updateLogicalWidth() { 2474 void LayoutBox::updateLogicalWidth() {
2475 LogicalExtentComputedValues computedValues; 2475 LogicalExtentComputedValues computedValues;
(...skipping 3269 matching lines...) Expand 10 before | Expand all | Expand 10 after
5745 5745
5746 void LayoutBox::MutableForPainting:: 5746 void LayoutBox::MutableForPainting::
5747 savePreviousContentBoxSizeAndLayoutOverflowRect() { 5747 savePreviousContentBoxSizeAndLayoutOverflowRect() {
5748 auto& rareData = layoutBox().ensureRareData(); 5748 auto& rareData = layoutBox().ensureRareData();
5749 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true; 5749 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true;
5750 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size(); 5750 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size();
5751 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect(); 5751 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect();
5752 } 5752 }
5753 5753
5754 } // namespace blink 5754 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698