Add check for missing visual rect updates and fix failures

third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/FrameView.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
@@ skipping 34 matching lines @@
 
   Element* container = document().getElementById("container");
   container->setAttribute(HTMLNames::styleAttr,
                           "transform: translateY(1000px);");
   document().updateStyleAndLayoutTree();
 
   EXPECT_EQ(scrollableArea->maximumScrollOffset().height(), 1000);
   EXPECT_TRUE(document().layoutView()->mayNeedPaintInvalidation());
 }
 
+TEST_F(PaintInvalidationTest, UpdateVisualRectOnFrameBorderWidthChange) {
+  setBodyInnerHTML(

[chrishtr, 2017/03/06 22:44:27]

if (REF::rootLayerScrollingEnabled())
  return

?

[Xianzhu, 2017/03/07 00:22:08]

This test should still pass for rootLayerScrolling().

I converted the test to parameterized test, but it failed with
rootLayerScrolling() enabled. Fixed by moving the added
setMayNeedPaintInvalidation() in FrameView::setFrameRect() out of the REF
conditions.

+      "<style>"
+      "  body { margin: 0 }"
+      "  iframe { width: 100px; height: 100px; border: none; }"
+      "</style>"
+      "<iframe id='iframe'></iframe>");
+
+  Element* iframe = document().getElementById("iframe");
+  LayoutView* childLayoutView = childDocument().layoutView();
+  EXPECT_EQ(LayoutRect(0, 0, 100, 100), childLayoutView->visualRect());
+
+  iframe->setAttribute(HTMLNames::styleAttr, "border: 20px solid blue");
+  document().view()->updateAllLifecyclePhases();
+  EXPECT_EQ(LayoutRect(20, 20, 100, 100), childLayoutView->visualRect());
+};
+
 }  // namespace
 
 }  // namespace blink