Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp

Issue 2733773004: Add check for missing visual rect updates and fix failures (Closed)
Patch Set: - Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
index 6a5712cd296d55d82d299592986ee6c8e244340c..02d85b35ddad78418e190f0d4d2ab6d9051ee2fb 100644
--- a/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
@@ -26,8 +26,13 @@ PaintInvalidationReason TablePaintInvalidator::invalidatePaintIfNeeded() {
// If any col changed background, we'll check all cells for background
// changes.
bool hasColChangedBackground = false;
+ bool visualRectChanged = m_context.oldVisualRect != m_context.newVisualRect;
for (LayoutTableCol* col = m_table.firstColumn(); col;
col = col->nextColumn()) {
+ // LayoutTableCol uses the table's localVisualRect(). Should check column
+ // for paint invalidation when table's visual rect changed.
+ if (visualRectChanged)
+ col->setMayNeedPaintInvalidation();
// This ensures that the backgroundChangedSinceLastPaintInvalidation flag
// is up-to-date.
col->ensureIsReadyForPaintInvalidation();
« no previous file with comments | « third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698