Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2733503003: [assembler] Make register definitions constexpr (Closed)

Created:
3 years, 9 months ago by Clemens Hammacher
Modified:
3 years, 9 months ago
Reviewers:
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[assembler] Make register definitions constexpr I originally needed this for the initialization of a constexpr array in the wasm lazy compile builtin, but since it's a bigger change, I now split it off as this separate CL. The style guide recommends constexpr over const, and even recommends to change existing code. I thus apply the constexprificaton over all headers that I touched anyway. I also remove the ARM64_DEFINE_REG_STATICS hack. It was introduced when merging in arm64 support more than three years ago, and I don't see the purpose for this. Also, some #defines can now be constexpr definitions, which was not possible before according to the comment. R=bmeurer@chromium.org, mstarzinger@chromium.org, ishell@chromium.org

Patch Set 1 #

Patch Set 2 : [assembler] Make register definitions constexpr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -503 lines) Patch
M src/arm/assembler-arm.h View 1 16 chunks +141 lines, -142 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 19 chunks +56 lines, -97 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 1 7 chunks +28 lines, -30 lines 0 comments Download
M src/mips/assembler-mips.h View 1 11 chunks +79 lines, -84 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 3 chunks +18 lines, -18 lines 0 comments Download
M src/mips64/assembler-mips64.h View 14 chunks +81 lines, -94 lines 0 comments Download
M src/x64/assembler-x64.h View 9 chunks +35 lines, -37 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (9 generated)
Clemens Hammacher
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-03 19:04:20 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733503003/1
3 years, 9 months ago (2017-03-03 19:04:24 UTC) #2
Clemens Hammacher
clemensh@chromium.org changed reviewers: - bmeurer@chromium.org, ishell@chromium.org, mstarzinger@chromium.org
3 years, 9 months ago (2017-03-03 19:04:26 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-03 19:30:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 9 months ago (2017-03-03 19:30:34 UTC) #5
Clemens Hammacher
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-06 09:24:06 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733503003/20001
3 years, 9 months ago (2017-03-06 09:24:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-06 09:51:46 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 09:51:47 UTC) #9
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698