Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2731523005: [wasm] Lazy compilation for asm.js (Closed)

Created:
3 years, 9 months ago by Clemens Hammacher
Modified:
3 years, 9 months ago
Reviewers:
CC:
Michael Hablich, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Lazy compilation for asm.js This CL adds general lazy compilation support to WebAssembly, according to the design described in the design doc (see referenced bug). It is not used currently, but I tested locally that all tests succeed if I enable it by default. With a later CL, we will enable lazy compilation by default for validate-asm. R=titzer@chromium.org, ahaas@chromium.org, bmeurer@chromium.org BUG=v8:5991

Patch Set 1 #

Patch Set 2 : Add ia32 #

Patch Set 3 : More constexpr #

Patch Set 4 : Rebase #

Patch Set 5 : Fix mipsel #

Patch Set 6 : Fix more platforms #

Patch Set 7 : [wasm] Lazy compilation for asm.js #

Patch Set 8 : [wasm] Lazy compilation for asm.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+726 lines, -56 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 2 3 4 5 6 7 1 chunk +29 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 2 3 4 5 6 1 chunk +35 lines, -0 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 2 3 4 5 6 1 chunk +27 lines, -0 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 2 3 4 5 6 1 chunk +35 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 3 4 5 6 9 chunks +39 lines, -17 lines 0 comments Download
M src/counters.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-wasm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/wasm/wasm-code-specialization.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +22 lines, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 1 2 3 4 5 6 15 chunks +208 lines, -32 lines 0 comments Download
M src/wasm/wasm-objects.h View 3 chunks +20 lines, -0 lines 0 comments Download
M src/wasm/wasm-objects.cc View 1 2 3 4 5 6 7 5 chunks +239 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2733503003 Patch 20001

Dependent Patchsets:

Issue 2728403002 Patch 40001

Messages

Total messages: 25 (25 generated)
Clemens Hammacher
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-03 13:49:42 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731523005/1
3 years, 9 months ago (2017-03-03 13:49:44 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-03 13:52:49 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/14080) v8_linux_mipsel_compile_rel on ...
3 years, 9 months ago (2017-03-03 13:52:50 UTC) #4
Clemens Hammacher
clemensh@chromium.org changed reviewers: - ahaas@chromium.org, bmeurer@chromium.org, titzer@chromium.org
3 years, 9 months ago (2017-03-03 14:25:15 UTC) #5
Clemens Hammacher
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-03 14:47:29 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731523005/20001
3 years, 9 months ago (2017-03-03 14:47:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-03 14:51:45 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/17675)
3 years, 9 months ago (2017-03-03 14:51:47 UTC) #9
Clemens Hammacher
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-03 16:14:04 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731523005/40001
3 years, 9 months ago (2017-03-03 16:14:14 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-03 16:18:03 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/30414)
3 years, 9 months ago (2017-03-03 16:18:04 UTC) #13
Clemens Hammacher
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-06 09:24:50 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731523005/60001
3 years, 9 months ago (2017-03-06 09:24:58 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-06 09:32:08 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/30443)
3 years, 9 months ago (2017-03-06 09:32:08 UTC) #17
Clemens Hammacher
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-06 10:23:59 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731523005/80001
3 years, 9 months ago (2017-03-06 10:24:08 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-06 10:48:54 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 9 months ago (2017-03-06 10:48:55 UTC) #21
Clemens Hammacher
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-06 16:08:30 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731523005/100001
3 years, 9 months ago (2017-03-06 16:08:36 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-06 16:34:58 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 16:34:59 UTC) #25 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698