Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2733363002: Update last few users of deprecated CreateShadowDrawLooper and remove (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, groby+bubble_chromium.org, sadrul, Matt Giuca, tfarina, jam, dcheng, rsesek+watch_chromium.org, msw+watch_chromium.org, darin-cc_chromium.org, hcarmona+bubble_chromium.org, kalyank, bruthig+ink_drop_chromium.org, rouslan+bubble_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update last few users of deprecated CreateShadowDrawLooper and remove it. As a general rule, doubling the blur values passed in will yield nearly identical visuals. The main difference is that ShadowValues::GetMargins() will now return the correct value because of the corrected blur values. For example, ShadowBorder will now set the correct margins. Previous to this change, the ShadowBorders in the AppList were clipped because of the incorrect margins. BUG=684627, 624175 TBR=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2733363002 Cr-Commit-Position: refs/heads/master@{#455672} Committed: https://chromium.googlesource.com/chromium/src/+/9ef3c96947ed010f07e1134c633b5761050fdf33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -66 lines) Patch
M ash/common/system/tray/tray_details_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/message_center/message_center_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/aura/gesture_nav_simple.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_constants.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/shadow_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/skia_paint_util.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/gfx/skia_paint_util.cc View 2 chunks +0 lines, -42 lines 0 comments Download
M ui/views/animation/ink_drop_painted_layer_delegates.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_border.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/toggle_button.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (20 generated)
Evan Stade
3 years, 9 months ago (2017-03-08 18:33:51 UTC) #11
sky
LGTM
3 years, 9 months ago (2017-03-08 21:00:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733363002/1
3 years, 9 months ago (2017-03-08 21:04:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/381254)
3 years, 9 months ago (2017-03-08 21:13:46 UTC) #19
Evan Stade
TBR sadrul for rename in gesture_nav_simple.cc
3 years, 9 months ago (2017-03-09 03:23:17 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733363002/1
3 years, 9 months ago (2017-03-09 03:23:46 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 05:18:00 UTC) #27
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ef3c96947ed010f07e1134c633b...

Powered by Google App Engine
This is Rietveld 408576698