Disentangle assembler from isolate.

Disentangle assembler from isolate.

This is a first step towards moving Turbofan code generation off the main thread.

Summary of the changes:
- AssemblerBase no longer has a pointer to the isolate. Instead, its
  constructor receives the few things that it needs from the isolate (on most
  architectures this is just the serializer_enabled flag).
- RelocInfo no longer has a pointer to the isolate. Instead, the functions
  that need it take it as an argument.  (There are currently still a few that
  implicitly access the isolate through a HeapObject.)
- The MacroAssembler now explicitly holds a pointer to the isolate (before, it
  used to get it from the Assembler).
- The jit_cookie also moved from AssemblerBase to the MacroAssemblers, since
  it's not used at all in the Assemblers.
- A few architectures implemented parts of the Assembler with the help
  of a Codepatcher that is based on MacroAssembler.  Since the Assembler no
  longer has the isolate, but the MacroAssembler still needs it, this doesn't 
  work anymore.  Instead, these Assemblers now use a new PatchingAssembler. 

BUG=v8:6048
Review-Url: https://codereview.chromium.org/2732273003
Cr-Commit-Position: refs/heads/master@{#43890}
Committed: https://chromium.googlesource.com/v8/v8/+/94b088ca3ccd3c974af63e1d1bfba8c9d8c10559

[Jarin, 2017-03-07 13:01:30]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2017-03-07 13:01:30]

This indeed looks like a good start.

[neis, 2017-03-16 14:57:56]

Description was changed from

==========
Disentangle assembler from isolate.

WIP

COMMIT=false
BUG=v8:6048
==========

to

==========
Disentangle assembler from isolate.

This is a first step towards moving Turbofan code generation off the main
thread.

Summary of the changes:
- AssemblerBase no longer has a pointer to the isolate. Instead, its
  constructor receives the few things that it needs from the isolate (on most
  architectures this is just the serializer_enabled flag).
- The MacroAssembler now explicitly holds a pointer to the isolate (before, it
  used to get it from the Assembler).
- The jit_cookie also moved from AssemblerBase to the MacroAssemblers, since
  it's not used at all in the Assemblers.
- A few architectures implemented parts of the Assembler with the help
  of a Codepatcher that is based on MacroAssembler.  Since the Assembler no
  longer has the isolate, but the MacroAssembler still needs it, this doesn't 
  work anymore.  Instead, these Assemblers now use a new PatchingAssembler. 

BUG=v8:6048
==========

[neis, 2017-03-16 14:57:56]

Description was changed from

==========
Disentangle assembler from isolate.

WIP

COMMIT=false
BUG=v8:6048
==========

to

==========
Disentangle assembler from isolate.

This is a first step towards moving Turbofan code generation off the main
thread.

Summary of the changes:
- AssemblerBase no longer has a pointer to the isolate. Instead, its
  constructor receives the few things that it needs from the isolate (on most
  architectures this is just the serializer_enabled flag).
- The MacroAssembler now explicitly holds a pointer to the isolate (before, it
  used to get it from the Assembler).
- The jit_cookie also moved from AssemblerBase to the MacroAssemblers, since
  it's not used at all in the Assemblers.
- A few architectures implemented parts of the Assembler with the help
  of a Codepatcher that is based on MacroAssembler.  Since the Assembler no
  longer has the isolate, but the MacroAssembler still needs it, this doesn't 
  work anymore.  Instead, these Assemblers now use a new PatchingAssembler. 

BUG=v8:6048
==========

[neis, 2017-03-16 14:59:34]

neis@chromium.org changed reviewers:
+ ulan@chromium.org

[neis, 2017-03-16 14:59:35]

PTAL

[neis, 2017-03-16 15:03:38]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 15:03:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 15:30:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 15:30:14]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-03-17 09:07:18]

lgtm, thanks!

[neis, 2017-03-17 09:19:55]

Description was changed from

==========
Disentangle assembler from isolate.

This is a first step towards moving Turbofan code generation off the main
thread.

Summary of the changes:
- AssemblerBase no longer has a pointer to the isolate. Instead, its
  constructor receives the few things that it needs from the isolate (on most
  architectures this is just the serializer_enabled flag).
- The MacroAssembler now explicitly holds a pointer to the isolate (before, it
  used to get it from the Assembler).
- The jit_cookie also moved from AssemblerBase to the MacroAssemblers, since
  it's not used at all in the Assemblers.
- A few architectures implemented parts of the Assembler with the help
  of a Codepatcher that is based on MacroAssembler.  Since the Assembler no
  longer has the isolate, but the MacroAssembler still needs it, this doesn't 
  work anymore.  Instead, these Assemblers now use a new PatchingAssembler. 

BUG=v8:6048
==========

to

==========
Disentangle assembler from isolate.

This is a first step towards moving Turbofan code generation off the main
thread.

Summary of the changes:
- AssemblerBase no longer has a pointer to the isolate. Instead, its
  constructor receives the few things that it needs from the isolate (on most
  architectures this is just the serializer_enabled flag).
- RelocInfo no longer has a pointer to the isolate. Instead, the functions
  that need it take it as an argument.  (There are currently still a few that
  implicitly access the isolate through a HeapObject.)
- The MacroAssembler now explicitly holds a pointer to the isolate (before, it
  used to get it from the Assembler).
- The jit_cookie also moved from AssemblerBase to the MacroAssemblers, since
  it's not used at all in the Assemblers.
- A few architectures implemented parts of the Assembler with the help
  of a Codepatcher that is based on MacroAssembler.  Since the Assembler no
  longer has the isolate, but the MacroAssembler still needs it, this doesn't 
  work anymore.  Instead, these Assemblers now use a new PatchingAssembler. 

BUG=v8:6048
==========

[Yang, 2017-03-17 09:20:54]

On 2017/03/17 09:07:18, Jarin wrote:
> lgtm, thanks!

src/debug and src/snapshot lgtm.

[ulan, 2017-03-17 09:47:07]

lgtm

[neis, 2017-03-17 09:51:54]

neis@chromium.org changed reviewers:
+ ahaas@chromium.org

[neis, 2017-03-17 09:51:55]

+ahaas for wasm

[ahaas, 2017-03-17 10:24:06]

ahaas@chromium.org changed reviewers:
+ yangguo@chromium.org

[ahaas, 2017-03-17 10:24:07]

wasm lgtm with nit

https://codereview.chromium.org/2732273003/diff/40001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2732273003/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:177:
it.rinfo()->set_target_address(target->GetIsolate(),
I think you could also just use {isolate}.

[neis, 2017-03-17 10:31:51]

https://codereview.chromium.org/2732273003/diff/40001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2732273003/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:177:
it.rinfo()->set_target_address(target->GetIsolate(),
On 2017/03/17 10:24:07, ahaas wrote:
> I think you could also just use {isolate}.

Acknowledged.

[neis, 2017-03-17 10:40:44]

The CQ bit was checked by neis@chromium.org

[neis, 2017-03-17 10:40:45]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
jarin@chromium.org, ahaas@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2732273003/#ps60001
(title: "Address feedback.")

[commit-bot: I haz the power, 2017-03-17 10:40:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 10:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 10:44:40]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36966)

[neis, 2017-03-17 10:55:35]

neis@chromium.org changed reviewers:
+ mvstanton@chromium.org

[neis, 2017-03-17 10:55:35]

neis@chromium.org changed reviewers:
+ mvstanton@chromium.org

[neis, 2017-03-17 10:55:36]

+mvstanton for ic/

[neis, 2017-03-17 10:55:36]

+mvstanton for ic/

[neis, 2017-03-17 10:58:31]

neis@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2017-03-17 10:59:01]

lgtm

[neis, 2017-03-17 10:59:25]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2017-03-17 10:59:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 11:18:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489748365278080,
"parent_rev": "10f7b7ecc686b34d13ac3fa5f789dfce1c963711", "commit_rev":
"94b088ca3ccd3c974af63e1d1bfba8c9d8c10559"}

[commit-bot: I haz the power, 2017-03-17 11:18:13]

Description was changed from

==========
Disentangle assembler from isolate.

This is a first step towards moving Turbofan code generation off the main
thread.

Summary of the changes:
- AssemblerBase no longer has a pointer to the isolate. Instead, its
  constructor receives the few things that it needs from the isolate (on most
  architectures this is just the serializer_enabled flag).
- RelocInfo no longer has a pointer to the isolate. Instead, the functions
  that need it take it as an argument.  (There are currently still a few that
  implicitly access the isolate through a HeapObject.)
- The MacroAssembler now explicitly holds a pointer to the isolate (before, it
  used to get it from the Assembler).
- The jit_cookie also moved from AssemblerBase to the MacroAssemblers, since
  it's not used at all in the Assemblers.
- A few architectures implemented parts of the Assembler with the help
  of a Codepatcher that is based on MacroAssembler.  Since the Assembler no
  longer has the isolate, but the MacroAssembler still needs it, this doesn't 
  work anymore.  Instead, these Assemblers now use a new PatchingAssembler. 

BUG=v8:6048
==========

to

==========
Disentangle assembler from isolate.

This is a first step towards moving Turbofan code generation off the main
thread.

Summary of the changes:
- AssemblerBase no longer has a pointer to the isolate. Instead, its
  constructor receives the few things that it needs from the isolate (on most
  architectures this is just the serializer_enabled flag).
- RelocInfo no longer has a pointer to the isolate. Instead, the functions
  that need it take it as an argument.  (There are currently still a few that
  implicitly access the isolate through a HeapObject.)
- The MacroAssembler now explicitly holds a pointer to the isolate (before, it
  used to get it from the Assembler).
- The jit_cookie also moved from AssemblerBase to the MacroAssemblers, since
  it's not used at all in the Assemblers.
- A few architectures implemented parts of the Assembler with the help
  of a Codepatcher that is based on MacroAssembler.  Since the Assembler no
  longer has the isolate, but the MacroAssembler still needs it, this doesn't 
  work anymore.  Instead, these Assemblers now use a new PatchingAssembler. 

BUG=v8:6048

Review-Url: https://codereview.chromium.org/2732273003
Cr-Commit-Position: refs/heads/master@{#43890}
Committed:
https://chromium.googlesource.com/v8/v8/+/94b088ca3ccd3c974af63e1d1bfba8c9d8c...
==========

[commit-bot: I haz the power, 2017-03-17 11:18:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/94b088ca3ccd3c974af63e1d1bfba8c9d8c...