src/x64/codegen-x64.cc - Issue 2732273003: Disentangle assembler from isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 2732273003: Disentangle assembler from isolate. (Closed)

Patch Set: Address feedback. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/codegen-x64.cc

diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc

index f8ed7cb687e30ea11c2964b4aa6da3018d30de2f..e16dbebd3c9800bb14f3e8e6899376f27b5b0593 100644

--- a/src/x64/codegen-x64.cc

+++ b/src/x64/codegen-x64.cc

@@ -49,7 +49,7 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) {

CodeDesc desc;

masm.GetCode(&desc);

- DCHECK(!RelocInfo::RequiresRelocation(desc));

+ DCHECK(!RelocInfo::RequiresRelocation(isolate, desc));

Assembler::FlushICache(isolate, buffer, actual_size);

base::OS::ProtectCode(buffer, actual_size);

« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »