src/ppc/codegen-ppc.cc - Issue 2732273003: Disentangle assembler from isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ppc/codegen-ppc.cc

Issue 2732273003: Disentangle assembler from isolate. (Closed)

Patch Set: Address feedback. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ppc/codegen-ppc.cc

diff --git a/src/ppc/codegen-ppc.cc b/src/ppc/codegen-ppc.cc

index 212e6db11d4409deb42821cbf24ea7b8a062a122..1d4cdd0fcb98fa44986ddb0b0504faa57f2ddf1b 100644

--- a/src/ppc/codegen-ppc.cc

+++ b/src/ppc/codegen-ppc.cc

@@ -40,7 +40,8 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) {

CodeDesc desc;

masm.GetCode(&desc);

- DCHECK(ABI_USES_FUNCTION_DESCRIPTORS || !RelocInfo::RequiresRelocation(desc));

+ DCHECK(ABI_USES_FUNCTION_DESCRIPTORS ||

+ !RelocInfo::RequiresRelocation(isolate, desc));

Assembler::FlushICache(isolate, buffer, actual_size);

base::OS::ProtectCode(buffer, actual_size);

« no previous file with comments | « src/ppc/assembler-ppc-inl.h ('k') | src/ppc/macro-assembler-ppc.h » ('j') | no next file with comments »