Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange

Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange

This patch makes |FormatBlockCommand::elementForFormatBlockCommand()| to take
|EphemeralRange| instead of |Range| object to avoid registering temporary
|Range| object to range update list to reduce memory usage and relocation cost
for improving code health.

BUG=691199
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2729823002
Cr-Commit-Position: refs/heads/master@{#455681}
Committed: https://chromium.googlesource.com/chromium/src/+/b66326f26629d4e161ad020ea34052c3f52598af

[yosin_UTC9, 2017-03-02 07:29:56]

Description was changed from

==========
2017-03-02T16:28:37

2017-03-02T16:26:01

BUG=
==========

to

==========
2017-03-02T16:28:37

2017-03-02T16:26:01

BUG=691199
==========

[yosin_UTC9, 2017-03-02 07:30:00]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 07:30:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-02 07:58:20]

Description was changed from

==========
2017-03-02T16:28:37

2017-03-02T16:26:01

BUG=691199
==========

to

==========
Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange

This patch makes |FormatBlockCommand::elementForFormatBlockCommand()| to take
|EphemeralRange| instead of |Range| object to avoid registering temporary
|Range| object to range update list to reduce memory usage and relocation cost
for improving code health.

BUG=691199
TEST=n/a; no behavior change
==========

[commit-bot: I haz the power, 2017-03-02 08:40:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 08:40:25]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-02 09:05:27]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-02 09:05:28]

PTAL

[yoichio, 2017-03-02 09:21:36]

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
(right):

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp:143:
const EphemeralRange& range) {
How about passing |selection| directly from caller and using
 selection.start/end().computeContainerNode() ?

[yosin_UTC9, 2017-03-02 10:05:43]

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
(right):

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp:143:
const EphemeralRange& range) {
On 2017/03/02 at 09:21:36, yoichio wrote:
> How about passing |selection| directly from caller and using
>  selection.start/end().computeContainerNode() ?

No, we don't want to increase usage of |VisibleSelection|.

[Xiaocheng, 2017-03-02 20:21:05]

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (left):

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:2079:
FormatBlockCommand::elementForFormatBlockCommand(firstRangeOf(selection));
This patch has conflict with https://codereview.chromium.org/2724333002.

Could you make this patch a dependant of that one?

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
(right):

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp:144:
Node* commonAncestor = Range::commonAncestorContainer(
How about waiting until https://codereview.chromium.org/2725603002 lands, and
then we can call |range.commonAncestorContainer()| directly?

[yoichio, 2017-03-03 01:56:17]

"BLOCKED BY 2729823002"
 2729823002 is this patch itself. Could you update?

[yosin_UTC9, 2017-03-09 04:09:55]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 04:10:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 04:18:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 04:18:56]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yosin_UTC9, 2017-03-09 05:18:40]

PTAL

Bots failures aren't related to this patch.

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (left):

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:2079:
FormatBlockCommand::elementForFormatBlockCommand(firstRangeOf(selection));
On 2017/03/02 at 20:21:05, Xiaocheng wrote:
> This patch has conflict with https://codereview.chromium.org/2724333002.
> 
> Could you make this patch a dependant of that one?

The patch is committed. There is no conflict anymore.

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
(right):

https://codereview.chromium.org/2729823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp:144:
Node* commonAncestor = Range::commonAncestorContainer(
On 2017/03/02 at 20:21:05, Xiaocheng wrote:
> How about waiting until https://codereview.chromium.org/2725603002 lands, and
then we can call |range.commonAncestorContainer()| directly?

Done.

[yoichio, 2017-03-09 05:47:33]

lgtm

[yosin_UTC9, 2017-03-09 05:48:05]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-09 05:48:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 06:35:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489038485006530,
"parent_rev": "35a17d3593ecde3b7cea1ad36ada111d659b974a", "commit_rev":
"b66326f26629d4e161ad020ea34052c3f52598af"}

[commit-bot: I haz the power, 2017-03-09 06:36:50]

Description was changed from

==========
Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange

This patch makes |FormatBlockCommand::elementForFormatBlockCommand()| to take
|EphemeralRange| instead of |Range| object to avoid registering temporary
|Range| object to range update list to reduce memory usage and relocation cost
for improving code health.

BUG=691199
TEST=n/a; no behavior change
==========

to

==========
Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange

This patch makes |FormatBlockCommand::elementForFormatBlockCommand()| to take
|EphemeralRange| instead of |Range| object to avoid registering temporary
|Range| object to range update list to reduce memory usage and relocation cost
for improving code health.

BUG=691199
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2729823002
Cr-Commit-Position: refs/heads/master@{#455681}
Committed:
https://chromium.googlesource.com/chromium/src/+/b66326f26629d4e161ad020ea340...
==========

[commit-bot: I haz the power, 2017-03-09 06:36:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b66326f26629d4e161ad020ea340...