third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h - Issue 2729823002: Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h

Issue 2729823002: Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange (Closed)

Patch Set: 2017-03-09T13:09:11 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h b/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h

index b069081eb0ce09087255274aabf5d41723270241..0ac8acae9d97d6663ee9ba9636a8ead3806c0647 100644

--- a/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h

@@ -27,6 +27,7 @@

#define FormatBlockCommand_h

#include "core/dom/QualifiedName.h"

+#include "core/editing/EphemeralRange.h"

#include "core/editing/Position.h"

#include "core/editing/VisiblePosition.h"

#include "core/editing/commands/ApplyBlockElementCommand.h"

@@ -35,7 +36,6 @@ namespace blink {

class Document;

class Element;

-class Range;

class CORE_EXPORT FormatBlockCommand final : public ApplyBlockElementCommand {

public:

@@ -46,7 +46,7 @@ class CORE_EXPORT FormatBlockCommand final : public ApplyBlockElementCommand {

bool preservesTypingStyle() const override { return true; }

- static Element* elementForFormatBlockCommand(Range*);

+ static Element* elementForFormatBlockCommand(const EphemeralRange&);

bool didApply() const { return m_didApply; }

private: