Get rid of VisibleSelection::firstRangeOf()

Get rid of VisibleSelection::firstRangeOf()

This patch gets rid of |VisibleSelection::firstRange()| by replacing call sites
with |createRange(firstEphmeralRange(...))| to make |Range| object creation
explicitly to prevent using temporary |Range| object for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2724333002
Cr-Commit-Position: refs/heads/master@{#454547}
Committed: https://chromium.googlesource.com/chromium/src/+/f72ffad58839a50563b41ba70adf941b2633f1c1

[yosin_UTC9, 2017-03-02 10:07:44]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 10:08:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-02 10:09:40]

Description was changed from

==========
2017-03-02T16:51:41

2017-03-02T16:50:31

BUG=
==========

to

==========
Get rid of VisibleSelection::firstRangeOf()

This patch gets rid of |VisibleSelection::firstRange()| by replacing call sites
with |createRange(firstEphmeralRange(...))| to make |Range| object creation
explicitly to prevent using temporary |Range| object for improving code health.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-02 10:10:24]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-02 10:10:25]

PTAL

Changes are in core/editing, module/accessibility and web/

[commit-bot: I haz the power, 2017-03-02 11:34:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 11:34:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2017-03-02 20:14:29]

Everything else looks good except...

https://codereview.chromium.org/2724333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
(right):

https://codereview.chromium.org/2724333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp:301:
DCHECK(!range);
Remove '!'

[tkent, 2017-03-02 23:13:54]

> This patch gets rid of |VisibleSelection::firstRange()| by replacing call
sites
> with |createRange(firstEphmeralRange(...))| to make |Range| object creation
> explicitly to prevent using temporary |Range| object for improving code
health.

Will you triage createRange() usage later?

[yosin_UTC9, 2017-03-03 04:19:24]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 04:19:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-03 04:22:06]

On 2017/03/02 at 23:13:54, tkent wrote:
> > This patch gets rid of |VisibleSelection::firstRange()| by replacing call
sites
> > with |createRange(firstEphmeralRange(...))| to make |Range| object creation
> > explicitly to prevent using temporary |Range| object for improving code
health.
> 
> Will you triage createRange() usage later?

Yes, we will. We also triage other Range constructor calls. Some of them can be
converted to EphemeralRange, but non-trivial. 

I think we've rewrite trivial usage.

[yosin_UTC9, 2017-03-03 04:22:35]

PTAL

https://codereview.chromium.org/2724333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
(right):

https://codereview.chromium.org/2724333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp:301:
DCHECK(!range);
On 2017/03/02 at 20:14:29, Xiaocheng wrote:
> Remove '!'

Done.
(my brain is still damaged...)

[commit-bot: I haz the power, 2017-03-03 05:40:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 05:40:17]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-03-03 06:32:28]

lgtm

[tkent, 2017-03-03 06:47:55]

lgtm

[dmazzoni, 2017-03-03 08:31:42]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-03-03 08:31:42]

lgtm for accessibility

[yosin_UTC9, 2017-03-03 08:39:30]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-03 08:39:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 08:43:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488530370987730,
"parent_rev": "6156524be2f7b2728e69da9da5d09d2db600f02d", "commit_rev":
"f72ffad58839a50563b41ba70adf941b2633f1c1"}

[commit-bot: I haz the power, 2017-03-03 08:44:23]

Description was changed from

==========
Get rid of VisibleSelection::firstRangeOf()

This patch gets rid of |VisibleSelection::firstRange()| by replacing call sites
with |createRange(firstEphmeralRange(...))| to make |Range| object creation
explicitly to prevent using temporary |Range| object for improving code health.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Get rid of VisibleSelection::firstRangeOf()

This patch gets rid of |VisibleSelection::firstRange()| by replacing call sites
with |createRange(firstEphmeralRange(...))| to make |Range| object creation
explicitly to prevent using temporary |Range| object for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2724333002
Cr-Commit-Position: refs/heads/master@{#454547}
Committed:
https://chromium.googlesource.com/chromium/src/+/f72ffad58839a50563b41ba70adf...
==========

[commit-bot: I haz the power, 2017-03-03 08:44:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f72ffad58839a50563b41ba70adf...