Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h

Issue 2729823002: Make FormatBlockCommand::elementForFormatBlockCommand() to take EphemeralRange (Closed)
Patch Set: 2017-03-09T13:09:11 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef FormatBlockCommand_h 26 #ifndef FormatBlockCommand_h
27 #define FormatBlockCommand_h 27 #define FormatBlockCommand_h
28 28
29 #include "core/dom/QualifiedName.h" 29 #include "core/dom/QualifiedName.h"
30 #include "core/editing/EphemeralRange.h"
30 #include "core/editing/Position.h" 31 #include "core/editing/Position.h"
31 #include "core/editing/VisiblePosition.h" 32 #include "core/editing/VisiblePosition.h"
32 #include "core/editing/commands/ApplyBlockElementCommand.h" 33 #include "core/editing/commands/ApplyBlockElementCommand.h"
33 34
34 namespace blink { 35 namespace blink {
35 36
36 class Document; 37 class Document;
37 class Element; 38 class Element;
38 class Range;
39 39
40 class CORE_EXPORT FormatBlockCommand final : public ApplyBlockElementCommand { 40 class CORE_EXPORT FormatBlockCommand final : public ApplyBlockElementCommand {
41 public: 41 public:
42 static FormatBlockCommand* create(Document& document, 42 static FormatBlockCommand* create(Document& document,
43 const QualifiedName& tagName) { 43 const QualifiedName& tagName) {
44 return new FormatBlockCommand(document, tagName); 44 return new FormatBlockCommand(document, tagName);
45 } 45 }
46 46
47 bool preservesTypingStyle() const override { return true; } 47 bool preservesTypingStyle() const override { return true; }
48 48
49 static Element* elementForFormatBlockCommand(Range*); 49 static Element* elementForFormatBlockCommand(const EphemeralRange&);
50 bool didApply() const { return m_didApply; } 50 bool didApply() const { return m_didApply; }
51 51
52 private: 52 private:
53 FormatBlockCommand(Document&, const QualifiedName& tagName); 53 FormatBlockCommand(Document&, const QualifiedName& tagName);
54 54
55 void formatSelection(const VisiblePosition& startOfSelection, 55 void formatSelection(const VisiblePosition& startOfSelection,
56 const VisiblePosition& endOfSelection, 56 const VisiblePosition& endOfSelection,
57 EditingState*) override; 57 EditingState*) override;
58 void formatRange(const Position& start, 58 void formatRange(const Position& start,
59 const Position& end, 59 const Position& end,
60 const Position& endOfSelection, 60 const Position& endOfSelection,
61 HTMLElement*&, 61 HTMLElement*&,
62 EditingState*) override; 62 EditingState*) override;
63 63
64 bool m_didApply; 64 bool m_didApply;
65 }; 65 };
66 66
67 } // namespace blink 67 } // namespace blink
68 68
69 #endif // FormatBlockCommand_h 69 #endif // FormatBlockCommand_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698