Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2729623007: Don't cancel download when dismissing the notification (Closed)

Created:
3 years, 9 months ago by qinmin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asanka, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't cancel download when dismissing the notification BUG=698321 Review-Url: https://codereview.chromium.org/2729623007 Cr-Commit-Position: refs/heads/master@{#454946} Committed: https://chromium.googlesource.com/chromium/src/+/18aa71703fa522fbd6445fe0e3113e9b98d3c3a4

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Messages

Total messages: 19 (10 generated)
qinmin
3 years, 9 months ago (2017-03-04 00:05:10 UTC) #2
qinmin
PTAL
3 years, 9 months ago (2017-03-04 00:05:21 UTC) #3
David Trainor- moved to gerrit
lgtm
3 years, 9 months ago (2017-03-04 04:06:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729623007/1
3 years, 9 months ago (2017-03-04 05:46:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/164788) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-04 05:49:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729623007/20001
3 years, 9 months ago (2017-03-06 17:17:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/165168) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-06 17:20:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729623007/40001
3 years, 9 months ago (2017-03-06 19:25:05 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:40:01 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/18aa71703fa522fbd6445fe0e311...

Powered by Google App Engine
This is Rietveld 408576698