chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java - Issue 2729623007: Don't cancel download when dismissing the notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

Issue 2729623007: Don't cancel download when dismissing the notification (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

index 6196475267e94d9e9b5e3d00013463fd43241138..27a518c27259c3c3c78a3b39a34712aa7ca94555 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

@@ -10,10 +10,8 @@ public interface DownloadServiceDelegate {

* Called to cancel a download.

* @param downloadGuid GUID of the download.

* @param isOffTheRecord Whether the download is off the record.

- * @param isNotificationDismissed Whether cancel is caused by dismissing the notification.

- void cancelDownload(String downloadGuid, boolean isOffTheRecord,

- boolean isNotificationDismissed);

+ void cancelDownload(String downloadGuid, boolean isOffTheRecord);

/**

* Called to pause a download.