chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java - Issue 2729623007: Don't cancel download when dismissing the notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 2729623007: Don't cancel download when dismissing the notification (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

index e339403e39051e9337abc2ae7336ddd45cb8bfe2..855c9116d92298cd4e1cae4a9ef8e4385763ba71 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

@@ -1192,9 +1192,8 @@ public class DownloadManagerService extends BroadcastReceiver implements

@Override

public void cancelDownload(

- String downloadGuid, boolean isOffTheRecord, boolean isNotificationDismissed) {

- nativeCancelDownload(getNativeDownloadManagerService(), downloadGuid, isOffTheRecord,

- isNotificationDismissed);

+ String downloadGuid, boolean isOffTheRecord) {

+ nativeCancelDownload(getNativeDownloadManagerService(), downloadGuid, isOffTheRecord);

removeDownloadProgress(downloadGuid);

recordDownloadFinishedUMA(DOWNLOAD_STATUS_CANCELLED, downloadGuid, 0);

}

@@ -1812,8 +1811,7 @@ public class DownloadManagerService extends BroadcastReceiver implements

private native void nativeResumeDownload(

long nativeDownloadManagerService, String downloadGuid, boolean isOffTheRecord);

private native void nativeCancelDownload(

- long nativeDownloadManagerService, String downloadGuid, boolean isOffTheRecord,

- boolean isNotificationDismissed);

+ long nativeDownloadManagerService, String downloadGuid, boolean isOffTheRecord);

private native void nativePauseDownload(long nativeDownloadManagerService, String downloadGuid,

boolean isOffTheRecord);

private native void nativeRemoveDownload(long nativeDownloadManagerService, String downloadGuid,

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java » ('j') | no next file with comments »