Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2020)

Unified Diff: chrome/browser/android/download/download_manager_service.cc

Issue 2729623007: Don't cancel download when dismissing the notification (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/download/download_manager_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/download/download_manager_service.cc
diff --git a/chrome/browser/android/download/download_manager_service.cc b/chrome/browser/android/download/download_manager_service.cc
index 5c825b5ae6ec26a57de1fbc6727e0ff90a0ea42c..8b0921a8fc6d971139b7e0cc4ef66888441b9ba4 100644
--- a/chrome/browser/android/download/download_manager_service.cc
+++ b/chrome/browser/android/download/download_manager_service.cc
@@ -259,13 +259,10 @@ void DownloadManagerService::CancelDownload(
JNIEnv* env,
jobject obj,
const JavaParamRef<jstring>& jdownload_guid,
- bool is_off_the_record,
- bool is_notification_dismissed) {
+ bool is_off_the_record) {
std::string download_guid = ConvertJavaStringToUTF8(env, jdownload_guid);
DownloadController::RecordDownloadCancelReason(
- is_notification_dismissed ?
- DownloadController::CANCEL_REASON_NOTIFICATION_DISMISSED :
- DownloadController::CANCEL_REASON_ACTION_BUTTON);
+ DownloadController::CANCEL_REASON_ACTION_BUTTON);
if (is_history_query_complete_ || is_off_the_record)
CancelDownloadInternal(download_guid, is_off_the_record);
else
« no previous file with comments | « chrome/browser/android/download/download_manager_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698