Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2729583004: Skip a few "using namespace" that we don't really need. (Closed)

Created:
3 years, 9 months ago by Daniel Bratell
Modified:
3 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip a few "using namespace" that we don't really need. The Chromium coding style doesn't allow "using namespace" at all and since the code will eventually adapt and they are causing issues with some experiments I rather remove them now. Review-Url: https://codereview.chromium.org/2729583004 Cr-Commit-Position: refs/heads/master@{#454449} Committed: https://chromium.googlesource.com/chromium/src/+/b7429fd5ffdff147d471ff27fda68e87ee1d7f23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TypeAhead.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLMetaCharsetParser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/DateTimeNumericFieldElement.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Daniel Bratell
PTAL
3 years, 9 months ago (2017-03-02 16:21:34 UTC) #2
fs
lgtm
3 years, 9 months ago (2017-03-02 16:29:56 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2730683004 Patch 1). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-02 16:48:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729583004/1
3 years, 9 months ago (2017-03-02 22:42:57 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 00:12:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7429fd5ffdff147d471ff27fda6...

Powered by Google App Engine
This is Rietveld 408576698