Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2722313007: Remove some unnecessary using namespaces and add include guards (Closed)

Created:
3 years, 9 months ago by Daniel Bratell
Modified:
3 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unnecessary using namespaces and add include guards The Chromium Code Style doesn't allow using namespace and when I looked at the code it seems some of them in layout are not even needed. This removes the ones that are not needed and adds explicit scoping at the one place it's needed. Also adding a missing header guard and remove an unused enum. Review-Url: https://codereview.chromium.org/2722313007 Cr-Commit-Position: refs/heads/master@{#454563} Committed: https://chromium.googlesource.com/chromium/src/+/a333b76c54e0058b23fa8f2ffb6a64dc53fbb6e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M third_party/WebKit/Source/core/layout/ColumnBalancer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSlider.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 2 chunks +6 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Daniel Bratell
fs, similar to the changes in the html folder.
3 years, 9 months ago (2017-03-02 17:26:10 UTC) #2
fs
lgtm
3 years, 9 months ago (2017-03-02 18:14:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722313007/1
3 years, 9 months ago (2017-03-03 09:39:24 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 11:10:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a333b76c54e0058b23fa8f2ffb6a...

Powered by Google App Engine
This is Rietveld 408576698