Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2729583004: Skip a few "using namespace" that we don't really need. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/forms/TypeAhead.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
index fe352c535ecfc9d2a09be45fb60f8816fffa66a6..3912b1b2d29a5406e93b53ddc53202bbacd87b11 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
@@ -74,8 +74,6 @@
#include "platform/instrumentation/tracing/TraceEvent.h"
#include "platform/text/PlatformLocale.h"
-using namespace WTF::Unicode;
-
namespace blink {
using namespace HTMLNames;
@@ -1678,7 +1676,7 @@ void HTMLSelectElement::defaultEventHandler(Event* event) {
KeyboardEvent* keyboardEvent = toKeyboardEvent(event);
if (!keyboardEvent->ctrlKey() && !keyboardEvent->altKey() &&
!keyboardEvent->metaKey() &&
- isPrintableChar(keyboardEvent->charCode())) {
+ WTF::Unicode::isPrintableChar(keyboardEvent->charCode())) {
typeAheadFind(keyboardEvent);
event->setDefaultHandled();
return;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/forms/TypeAhead.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698