Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2729433002: bluetooth: Better disconnected error messages for GATT operations. (Closed)

Created:
3 years, 9 months ago by ortuno
Modified:
3 years, 9 months ago
Reviewers:
scheib, dcheng
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Better disconnected error messages for GATT operations. Changes characteristic.readValue/writeValue/getDescriptor(s) and descriptor.readValue/writeValue to return a more actionable error. BUG=684445 Review-Url: https://codereview.chromium.org/2729433002 Cr-Commit-Position: refs/heads/master@{#455633} Committed: https://chromium.googlesource.com/chromium/src/+/1372de15eab0d9365f7b3b0d006eb1a52d47edf6

Patch Set 1 #

Patch Set 2 : remove unused enums #

Patch Set 3 : Merge branch 'bluetooth-connect-error-services' into bluetooth-connected-error-operations #

Patch Set 4 : fix conflict #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -151 lines) Patch
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-before-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-error-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-success-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-before-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-error-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-success-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-disconnects-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-disconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-reconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-reconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-disconnect-called-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-disconnect-called-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-garbage-collection-ran-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-garbage-collection-ran-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-reconnect-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-reconnect-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-disconnects-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-disconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-reconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-reconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-disconnect-called-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-disconnect-called-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-garbage-collection-ran-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-garbage-collection-ran-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-reconnect-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-reconnect-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/device-reconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-device-disconnects-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-disconnect-called-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-garbage-collection-ran-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/reconnect-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-disconnects-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-disconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-reconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-reconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-disconnect-called-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-disconnect-called-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-garbage-collection-ran-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-garbage-collection-ran-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-reconnect-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-reconnect-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-disconnects-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-disconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-reconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-reconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-disconnect-called-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-disconnect-called-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-garbage-collection-ran-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-garbage-collection-ran-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-reconnect-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-reconnect-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-disconnects-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-disconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-reconnects-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-reconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-disconnect-called-before.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-disconnect-called-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-reconnect-during-error.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-reconnect-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-before.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-reconnects-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-reconnects-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-before.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-garbage-collection-ran-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-garbage-collection-ran-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-reconnect-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-reconnect-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-disconnects-before.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-disconnects-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-disconnects-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-reconnects-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-reconnects-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-disconnect-called-before.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-disconnect-called-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-disconnect-called-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-garbage-collection-ran-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-garbage-collection-ran-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-reconnect-during-error.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-reconnect-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 1 2 3 4 9 chunks +15 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom View 1 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 29 (14 generated)
ortuno
scheib: PTAL
3 years, 9 months ago (2017-03-01 20:46:37 UTC) #6
scheib
lgtm
3 years, 9 months ago (2017-03-04 19:13:49 UTC) #7
ortuno
dcheng: PTAL
3 years, 9 months ago (2017-03-07 23:57:01 UTC) #13
dcheng
mojom lgtm
3 years, 9 months ago (2017-03-08 23:00:19 UTC) #14
dcheng
mojom lgtm
3 years, 9 months ago (2017-03-08 23:00:19 UTC) #15
dcheng
mojom lgtm
3 years, 9 months ago (2017-03-08 23:00:19 UTC) #16
dcheng
mojom lgtm
3 years, 9 months ago (2017-03-08 23:00:19 UTC) #17
dcheng
mojom lgtm
3 years, 9 months ago (2017-03-08 23:00:19 UTC) #18
dcheng
mojom lgtm
3 years, 9 months ago (2017-03-08 23:00:20 UTC) #19
dcheng
mojom lgtm
3 years, 9 months ago (2017-03-08 23:00:20 UTC) #20
dcheng
mojom lgtm
3 years, 9 months ago (2017-03-08 23:00:21 UTC) #21
dcheng
mojom lgtm
3 years, 9 months ago (2017-03-08 23:00:24 UTC) #22
ortuno
wow! 9 lgtms! glad you liked the patch ;)
3 years, 9 months ago (2017-03-08 23:05:22 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729433002/80001
3 years, 9 months ago (2017-03-08 23:06:23 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 01:50:11 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1372de15eab0d9365f7b3b0d006e...

Powered by Google App Engine
This is Rietveld 408576698