bluetooth: Better disconnected error messages for characteristic retrieval.

bluetooth: Better disconnected error messages for characteristic retrieval.

Also refactor how disconnected messages are generated.

BUG=684445
Review-Url: https://codereview.chromium.org/2721233002
Cr-Commit-Position: refs/heads/master@{#455413}
Committed: https://chromium.googlesource.com/chromium/src/+/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e

[ortuno, 2017-03-01 02:27:23]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 02:28:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 03:04:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 03:04:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ortuno, 2017-03-01 05:26:58]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 05:27:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 07:09:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 07:09:50]

Dry run: This issue passed the CQ dry run.

[ortuno, 2017-03-01 20:46:22]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2017-03-04 19:07:31]

lgtm with comment fix

https://codereview.chromium.org/2721233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/bluetooth/BluetoothError.h (right):

https://codereview.chromium.org/2721233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothError.h:14: // Used
generate DOMExceptions for errors when the device is not connected.
Grammar is odd here. Should this be: "Used when generating DOMExceptions ..."?
Also, the comment will rot easily if we ever have another need for it, so maybe
just generalize the comment.

[ortuno, 2017-03-07 03:53:30]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 03:54:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 03:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:57:42]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[ortuno, 2017-03-07 04:09:09]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 04:09:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2017-03-07 04:18:20]

Thanks!

https://codereview.chromium.org/2721233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/bluetooth/BluetoothError.h (right):

https://codereview.chromium.org/2721233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothError.h:14: // Used
generate DOMExceptions for errors when the device is not connected.
On 2017/03/04 at 19:07:31, scheib wrote:
> Grammar is odd here. Should this be: "Used when generating DOMExceptions ..."?
Also, the comment will rot easily if we ever have another need for it, so maybe
just generalize the comment.

Done.

[ortuno, 2017-03-07 05:14:16]

The CQ bit was unchecked by ortuno@chromium.org

[ortuno, 2017-03-07 05:14:23]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2017-03-07 05:14:23]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2721233002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-07 05:15:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 05:23:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 05:23:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ortuno, 2017-03-07 05:25:59]

ortuno@chromium.org changed reviewers:
+ dcheng@chromium.org

[ortuno, 2017-03-07 05:25:59]

dcheng: PTAL

[dcheng, 2017-03-07 08:19:37]

lgtm

https://codereview.chromium.org/2721233002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp (right):

https://codereview.chromium.org/2721233002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp:15: }
Super minor nit:
Add // namespace
And a new line before (to match) or remove the newline before (again, to match)

[ortuno, 2017-03-07 22:23:59]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2017-03-07 22:24:00]

Thanks!

https://codereview.chromium.org/2721233002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp (right):

https://codereview.chromium.org/2721233002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp:15: }
On 2017/03/07 at 08:19:36, dcheng wrote:
> Super minor nit:
> Add // namespace
> And a new line before (to match) or remove the newline before (again, to
match)

Done.

[ortuno, 2017-03-07 22:24:01]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2721233002/#ps120001
(title: "Address dcheng's comments")

[commit-bot: I haz the power, 2017-03-07 22:25:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 02:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 02:43:37]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ortuno, 2017-03-08 07:25:42]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2017-03-08 07:26:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 09:24:17]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1488957942387560,
"parent_rev": "5b444f201a0e88282af902010b5c29c808c4fadc", "commit_rev":
"c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e"}

[commit-bot: I haz the power, 2017-03-08 09:24:55]

Description was changed from

==========
bluetooth: Better disconnected error messages for characteristic retrieval.

Also refactor how disconnected messages are generated.

BUG=684445
==========

to

==========
bluetooth: Better disconnected error messages for characteristic retrieval.

Also refactor how disconnected messages are generated.

BUG=684445

Review-Url: https://codereview.chromium.org/2721233002
Cr-Commit-Position: refs/heads/master@{#455413}
Committed:
https://chromium.googlesource.com/chromium/src/+/c71e0a42a3eb47e551bafaa4e5d5...
==========

[commit-bot: I haz the power, 2017-03-08 09:24:57]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/c71e0a42a3eb47e551bafaa4e5d5...