Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2728813002: bluetooth: Improve error message for retrieving Descriptors when disconnecting (Closed)

Created:
3 years, 9 months ago by ortuno
Modified:
3 years, 9 months ago
Reviewers:
scheib
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Improve error message for retrieving Descriptors when disconnecting Changes characteristic.getDescriptor(s) to return a more actionable error. BUG=684445 Review-Url: https://codereview.chromium.org/2728813002 Cr-Commit-Position: refs/heads/master@{#455929} Committed: https://chromium.googlesource.com/chromium/src/+/258758c687d31cc18e1f9f0395a8714df0187202

Patch Set 1 #

Patch Set 2 : Merge branch 'bluetooth-connected-error-operations' into bluetooth-connected-error-descriptors #

Patch Set 3 : rebase #

Patch Set 4 : Merge branch 'bluetooth-connected-error-operations' into bluetooth-connected-error-descriptors #

Patch Set 5 : Fix conflict error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+966 lines, -766 lines) Patch
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-device-disconnects-before.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-device-disconnects-during-error.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-device-disconnects-during-success.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-disconnect-called-before.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-disconnect-called-during-error.html View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-disconnect-called-during-success.html View 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html View 1 chunk +20 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-success.html View 1 chunk +19 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-before.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-during-error.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-before.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-during-error.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-during-success.html View 1 chunk +0 lines, -32 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-before.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-before-with-uuid.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-error.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-error-with-uuid.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-success.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-success-with-uuid.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-before.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-before-with-uuid.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-error.html View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-error-with-uuid.html View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-success.html View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-success-with-uuid.html View 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error.html View 1 chunk +20 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error-with-uuid.html View 1 chunk +20 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success.html View 1 chunk +19 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success-with-uuid.html View 1 chunk +19 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-before.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-before-with-uuid.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-error.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-error-with-uuid.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-success-with-uuid.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-before.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-before-with-uuid.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-error.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-error-with-uuid.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-success.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-success-with-uuid.html View 1 chunk +0 lines, -32 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-device-disconnects-before.js View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-device-disconnects-during-error.js View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-device-disconnects-during-success.js View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-disconnect-called-before.js View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-disconnect-called-during-error.js View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-disconnect-called-during-success.js View 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-error.js View 1 chunk +22 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-success.js View 1 chunk +21 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-before.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-during-error.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-during-success.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-before.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-during-error.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-during-success.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 1 2 3 4 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (21 generated)
ortuno
scheib: PTAL
3 years, 9 months ago (2017-03-01 23:50:28 UTC) #2
scheib
lgtm, but maybe change your git cl upload --similarity 10 to help reviews like this.
3 years, 9 months ago (2017-03-04 19:17:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728813002/80001
3 years, 9 months ago (2017-03-10 00:40:48 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 00:48:51 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/258758c687d31cc18e1f9f0395a8...

Powered by Google App Engine
This is Rietveld 408576698