Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp

Issue 2729433002: bluetooth: Better disconnected error messages for GATT operations. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
index 4fe20c8ad5000360757845796d0de9ca36027cbf..4cb5ad012c374437fb8b7dfe558e481bfe2555b7 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
@@ -27,6 +27,9 @@ DOMException* BluetoothError::createNotConnectedException(
case BluetoothOperation::CharacteristicsRetrieval:
operationString = "retrieve characteristics";
break;
+ case BluetoothOperation::GATT:
+ operationString = "perform GATT operations";
+ break;
}
return DOMException::create(
@@ -119,10 +122,6 @@ DOMException* BluetoothError::createDOMException(
"GATT operation already in progress.");
MAP_ERROR(UNTRANSLATED_CONNECT_ERROR_CODE, NetworkError,
"Unknown ConnectErrorCode.");
- MAP_ERROR(GATT_SERVER_NOT_CONNECTED, NetworkError,
- "GATT Server is disconnected. Cannot perform GATT operations.");
- MAP_ERROR(GATT_SERVER_DISCONNECTED, NetworkError,
- "GATT Server disconnected while performing a GATT operation.");
// NotFoundErrors:
MAP_ERROR(WEB_BLUETOOTH_NOT_SUPPORTED, NotFoundError,

Powered by Google App Engine
This is Rietveld 408576698