Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag.

Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag.

It doesn't need to be a settings because it is not used on a document
basis but on a platform basis. A runtime enabled flag has a lower
overhead and is easier to work with because there is no need for a
settings object to be available, making tests easier to write.

BUG=698237
Review-Url: https://codereview.chromium.org/2728133002
Cr-Commit-Position: refs/heads/master@{#454771}
Committed: https://chromium.googlesource.com/chromium/src/+/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81

[mlamouri (slow - plz ping), 2017-03-03 14:31:14]

mlamouri@chromium.org changed reviewers:
+ avayvod@chromium.org, esprehn@chromium.org, lcwu@chromium.org

[mlamouri (slow - plz ping), 2017-03-03 14:31:15]

lcwu@, PTAL at chromecast/ changes.

esprehn@, PTAL at content/ and Blink changes.

avayvod@, PTAL at media related changes.

Thanks :)

[mlamouri (slow - plz ping), 2017-03-03 14:31:20]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 14:31:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 14:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 14:47:46]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[halliwell, 2017-03-03 15:26:28]

halliwell@chromium.org changed reviewers:
+ halliwell@chromium.org

[halliwell, 2017-03-03 15:26:29]

https://codereview.chromium.org/2728133002/diff/1/chromecast/renderer/cast_co...
File chromecast/renderer/cast_content_renderer_client.cc (right):

https://codereview.chromium.org/2728133002/diff/1/chromecast/renderer/cast_co...
chromecast/renderer/cast_content_renderer_client.cc:151:
WebRuntimeFeatures::enableMediaControlsOverlayPlayButton(false);
do you need to include a header for WebRuntimeFeatures?

[mlamouri (slow - plz ping), 2017-03-03 17:25:03]

On 2017/03/03 at 15:26:29, halliwell wrote:
>
https://codereview.chromium.org/2728133002/diff/1/chromecast/renderer/cast_co...
> File chromecast/renderer/cast_content_renderer_client.cc (right):
> 
>
https://codereview.chromium.org/2728133002/diff/1/chromecast/renderer/cast_co...
> chromecast/renderer/cast_content_renderer_client.cc:151:
WebRuntimeFeatures::enableMediaControlsOverlayPlayButton(false);
> do you need to include a header for WebRuntimeFeatures?

Yes :)

[mlamouri (slow - plz ping), 2017-03-03 17:26:16]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[mlamouri (slow - plz ping), 2017-03-03 17:26:19]

Added header. PTAL :)

[commit-bot: I haz the power, 2017-03-03 17:26:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-03-03 17:35:08]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 17:35:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 17:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 17:52:16]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[mlamouri (slow - plz ping), 2017-03-03 17:55:10]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 17:55:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[halliwell, 2017-03-03 18:30:51]

On 2017/03/03 17:26:19, mlamouri wrote:
> Added header. PTAL :)

chromecast/ lgtm

[commit-bot: I haz the power, 2017-03-03 19:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 19:24:24]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-03-03 21:46:32]

lgtm

[mlamouri (slow - plz ping), 2017-03-04 13:40:55]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2017-03-04 13:41:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 13:44:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488634855808030,
"parent_rev": "3665df287a6774280935e96a466271ec4acbe9f9", "commit_rev":
"48a24fcc7bcf3f9c02faf6b1e949eed37f246c81"}

[commit-bot: I haz the power, 2017-03-04 13:45:23]

Description was changed from

==========
Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag.

It doesn't need to be a settings because it is not used on a document
basis but on a platform basis. A runtime enabled flag has a lower
overhead and is easier to work with because there is no need for a
settings object to be available, making tests easier to write.

BUG=698237
==========

to

==========
Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag.

It doesn't need to be a settings because it is not used on a document
basis but on a platform basis. A runtime enabled flag has a lower
overhead and is easier to work with because there is no need for a
settings object to be available, making tests easier to write.

BUG=698237

Review-Url: https://codereview.chromium.org/2728133002
Cr-Commit-Position: refs/heads/master@{#454771}
Committed:
https://chromium.googlesource.com/chromium/src/+/48a24fcc7bcf3f9c02faf6b1e949...
==========

[commit-bot: I haz the power, 2017-03-04 13:45:25]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/48a24fcc7bcf3f9c02faf6b1e949...