content/renderer/render_view_impl.cc - Issue 2728133002: Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 2728133002: Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag. (Closed)

Patch Set: should create a cast target Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 85a9fa9165edb0e29a705f97cb1c2731c7a74ee8..09fd4bb6ba8b2fbc9c40e7addaf4b58e77fcb138 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1025,7 +1025,6 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,

web_view->setIgnoreViewportTagScaleLimits(prefs.force_enable_zoom);

settings->setAutoZoomFocusedNodeToLegibleScale(true);

settings->setDoubleTapToZoomEnabled(prefs.double_tap_to_zoom_enabled);

- settings->setMediaControlsOverlayPlayButtonEnabled(true);

settings->setMediaPlaybackRequiresUserGesture(

prefs.user_gesture_required_for_media_playback);

settings->setMediaPlaybackGestureWhitelistScope(