third_party/WebKit/Source/core/html/shadow/MediaControls.cpp - Issue 2728133002: Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2728133002: Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag. (Closed)

Patch Set: should create a cast target Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

index 087b1013c313014963936a4221c8eedf8a6e6212..93bd45e959c756b0391ac063ab2d066cf54774e4 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

@@ -222,8 +222,7 @@ void MediaControls::initializeControls() {

MediaControlOverlayEnclosureElement* overlayEnclosure =

MediaControlOverlayEnclosureElement::create(*this);

- if (document().settings() &&

- document().settings()->getMediaControlsOverlayPlayButtonEnabled()) {

+ if (RuntimeEnabledFeatures::mediaControlsOverlayPlayButtonEnabled()) {

MediaControlOverlayPlayButtonElement* overlayPlayButton =

MediaControlOverlayPlayButtonElement::create(*this);

m_overlayPlayButton = overlayPlayButton;