Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Unified Diff: chromecast/renderer/cast_content_renderer_client.cc

Issue 2728133002: Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag. (Closed)
Patch Set: should create a cast target Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/renderer/cast_content_renderer_client.h ('k') | content/child/runtime_features.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/renderer/cast_content_renderer_client.cc
diff --git a/chromecast/renderer/cast_content_renderer_client.cc b/chromecast/renderer/cast_content_renderer_client.cc
index 57089adefc565527a85bf185f75c3a341b5b0280..2092aa1d43f07318ed2bb2d68aab4bb6c3579b29 100644
--- a/chromecast/renderer/cast_content_renderer_client.cc
+++ b/chromecast/renderer/cast_content_renderer_client.cc
@@ -26,6 +26,7 @@
#include "services/service_manager/public/cpp/interface_provider.h"
#include "third_party/WebKit/public/platform/WebColor.h"
#include "third_party/WebKit/public/web/WebFrameWidget.h"
+#include "third_party/WebKit/public/web/WebRuntimeFeatures.h"
#include "third_party/WebKit/public/web/WebSettings.h"
#include "third_party/WebKit/public/web/WebView.h"
@@ -98,9 +99,6 @@ void CastContentRendererClient::RenderViewCreated(
blink::WebFrameWidget* web_frame_widget = render_view->GetWebFrameWidget();
web_frame_widget->setBaseBackgroundColor(kColorBlack);
- // Settings for ATV (Android defaults are not what we want):
- webview->settings()->setMediaControlsOverlayPlayButtonEnabled(false);
-
// Disable application cache as Chromecast doesn't support off-line
// application running.
webview->settings()->setOfflineWebApplicationCacheEnabled(false);
@@ -148,5 +146,11 @@ bool CastContentRendererClient::AllowMediaSuspend() {
return false;
}
+void CastContentRendererClient::
+ SetRuntimeFeaturesDefaultsBeforeBlinkInitialization() {
+ // Settings for ATV (Android defaults are not what we want).
+ blink::WebRuntimeFeatures::enableMediaControlsOverlayPlayButton(false);
+}
+
} // namespace shell
} // namespace chromecast
« no previous file with comments | « chromecast/renderer/cast_content_renderer_client.h ('k') | content/child/runtime_features.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698