Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2727523002: Reland of Make generate_gradle.py work with preview SDKs. (Closed)

Created:
3 years, 9 months ago by agrieve
Modified:
3 years, 9 months ago
Reviewers:
nyquist, estevenson
CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org, awdf, Peter Wen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make generate_gradle.py work with preview SDKs This just tweaks the values of buildToolsVersion and compileSdkVersion, which were not being set in a way compatible with preview SDKs. Reverted in: https://codereview.chromium.org/2722973002/ Reason for reland: Fixed up non-absolute path. TBR=estevenson@chromium.org,nyquist@chromium.org BUG=620034 Review-Url: https://codereview.chromium.org/2727523002 Cr-Commit-Position: refs/heads/master@{#453827} Committed: https://chromium.googlesource.com/chromium/src/+/46eff9b374a4635979acef9a292682504f25ff2c

Patch Set 1 #

Patch Set 2 : make relative to output dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M build/android/gradle/android.jinja View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/gradle/generate_gradle.py View 1 3 chunks +10 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
agrieve
Created Reland of Make generate_gradle.py work with preview SDKs.
3 years, 9 months ago (2017-03-01 02:16:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727523002/50001
3 years, 9 months ago (2017-03-01 03:31:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:50001) as https://chromium.googlesource.com/chromium/src/+/46eff9b374a4635979acef9a292682504f25ff2c
3 years, 9 months ago (2017-03-01 03:37:59 UTC) #10
nyquist
3 years, 9 months ago (2017-03-01 06:07:17 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698