Make generate_gradle.py work with preview SDKs.

Make generate_gradle.py work with preview SDKs.

This just tweaks the values of buildToolsVersion and compileSdkVersion,
which were not being set in a way compatible with preview SDKs.

BUG=620034
Review-Url: https://codereview.chromium.org/2724513003
Cr-Commit-Position: refs/heads/master@{#453737}
Committed: https://chromium.googlesource.com/chromium/src/+/1a04e1cf3d4912300d625a57318bc6f2ba53ba79

[agrieve, 2017-02-28 18:40:58]

Description was changed from

==========
Make generate_gradle.py work with preview SDKs.

This just tweaks the values of buildToolsVersion and compileSdkVersion,
which were not being set in a way compatible with preview SDKs.

BUG=620034
==========

to

==========
Make generate_gradle.py work with preview SDKs.

This just tweaks the values of buildToolsVersion and compileSdkVersion,
which were not being set in a way compatible with preview SDKs.

BUG=620034
==========

[agrieve, 2017-02-28 18:40:58]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[estevenson, 2017-02-28 19:40:47]

lgtm

lgtm

[agrieve, 2017-02-28 20:26:54]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-02-28 20:27:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 23:22:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488313614565080, "parent_rev":
"66ab3f4789a3ee5592027963a3660ec20de8503a", "commit_rev":
"1a04e1cf3d4912300d625a57318bc6f2ba53ba79"}

[commit-bot: I haz the power, 2017-02-28 23:22:53]

Description was changed from

==========
Make generate_gradle.py work with preview SDKs.

This just tweaks the values of buildToolsVersion and compileSdkVersion,
which were not being set in a way compatible with preview SDKs.

BUG=620034
==========

to

==========
Make generate_gradle.py work with preview SDKs.

This just tweaks the values of buildToolsVersion and compileSdkVersion,
which were not being set in a way compatible with preview SDKs.

BUG=620034

Review-Url: https://codereview.chromium.org/2724513003
Cr-Commit-Position: refs/heads/master@{#453737}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a04e1cf3d4912300d625a57318b...
==========

[commit-bot: I haz the power, 2017-02-28 23:22:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a04e1cf3d4912300d625a57318b...

[nyquist, 2017-03-01 01:22:12]

nyquist@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2017-03-01 01:22:12]

https://codereview.chromium.org/2724513003/diff/1/build/android/gradle/genera...
File build/android/gradle/generate_gradle.py (right):

https://codereview.chromium.org/2724513003/diff/1/build/android/gradle/genera...
build/android/gradle/generate_gradle.py:518:
os.path.join(build_vars['android_sdk_build_tools'], 'source.properties'))
In my local checkout, os.getcwd() ends up being src/ if I run the command from
src/, so now what used to work fails with:
Traceback (most recent call last):
  File "/...snip.../chromium/src/build/android/gradle/generate_gradle.py", line
747, in <module>
    main()
  File "/...snip.../chromium/src/build/android/gradle/generate_gradle.py", line
708, in main
    data = _GenerateGradleFile(entry, generator, build_vars, jinja_processor)
  File "/...snip...t/chromium/src/build/android/gradle/generate_gradle.py", line
520, in _GenerateGradleFile
    os.path.join(build_vars['android_sdk_build_tools'], 'source.properties'))
  File "/...snip.../chromium/src/build/android/gradle/generate_gradle.py", line
96, in _ReadPropertiesFile
    with open(path) as f:
IOError: [Errno 2] No such file or directory:
'../../third_party/android_tools/sdk/build-tools/24.0.2/source.properties'


But if I cd into my out/Default (or whatever build place), and re-run the
command, it works.

[agrieve, 2017-03-01 01:24:16]

https://codereview.chromium.org/2724513003/diff/1/build/android/gradle/genera...
File build/android/gradle/generate_gradle.py (right):

https://codereview.chromium.org/2724513003/diff/1/build/android/gradle/genera...
build/android/gradle/generate_gradle.py:518:
os.path.join(build_vars['android_sdk_build_tools'], 'source.properties'))
On 2017/03/01 01:22:12, nyquist wrote:
> In my local checkout, os.getcwd() ends up being src/ if I run the command from
> src/, so now what used to work fails with:
> Traceback (most recent call last):
>   File "/...snip.../chromium/src/build/android/gradle/generate_gradle.py",
line
> 747, in <module>
>     main()
>   File "/...snip.../chromium/src/build/android/gradle/generate_gradle.py",
line
> 708, in main
>     data = _GenerateGradleFile(entry, generator, build_vars, jinja_processor)
>   File "/...snip...t/chromium/src/build/android/gradle/generate_gradle.py",
line
> 520, in _GenerateGradleFile
>     os.path.join(build_vars['android_sdk_build_tools'], 'source.properties'))
>   File "/...snip.../chromium/src/build/android/gradle/generate_gradle.py",
line
> 96, in _ReadPropertiesFile
>     with open(path) as f:
> IOError: [Errno 2] No such file or directory:
> '../../third_party/android_tools/sdk/build-tools/24.0.2/source.properties'
> 
> 
> But if I cd into my out/Default (or whatever build place), and re-run the
> command, it works.

Doh! Clearly wrong. I'll revert & reland.

[agrieve, 2017-03-01 01:24:38]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2722973002/ by agrieve@chromium.org.

The reason for reverting is: Breaks when CWD != output_dir.